Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised the filter ID description #162

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Revised the filter ID description #162

merged 5 commits into from
Nov 25, 2024

Conversation

brtnfld
Copy link
Contributor

@brtnfld brtnfld commented Nov 22, 2024

Revised PR #158 regarding the filter ID description to align with the specifications outlined in the HDF5 documentation.

@brtnfld
Copy link
Contributor Author

brtnfld commented Nov 22, 2024

@markcmiller86, I revised the paragraph of PR #158

@markcmiller86
Copy link
Contributor

@markcmiller86, I revised the paragraph of PR #158

Is it true that 0...256 are also "reservable" by a 3rd party? Or, do you just want to avoid talking about that part of it in this doc? Only reason I ask is there is header file content suggesting that. Maybe the original doc was fine then.

@brtnfld
Copy link
Contributor Author

brtnfld commented Nov 22, 2024

@markcmiller86, I revised the paragraph of PR #158

Is it true that 0...256 are also "reservable" by a 3rd party? Or, do you just want to avoid talking about that part of it in this doc? Only reason I ask is there is header file content suggesting that. Maybe the original doc was fine then.

You are correct, H5Zpublic. It is okay to be more detailed as I can not find this information by searching our HDF5 documentation. If so, I'll remove the reference to VOLs and update the PR.

/**
 * \brief Filter identifiers
 *
 * \details Values 0 through 255 are for filters defined by the HDF5 library.
 *          Values 256 through 511 are available for testing new filters.
 *          Subsequent values should be obtained from the HDF5 development team
 *          at mailto:[email protected]. These values will never change because
 *          they appear in the HDF5 files.
 */

@brtnfld
Copy link
Contributor Author

brtnfld commented Nov 22, 2024

I will work out some issues in the HDF5 documentation on this topic and then get back to this.

@lrknox lrknox merged commit 8e8e4d3 into HDFGroup:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants