Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verbiage about reserved ids #158

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

markcmiller86
Copy link
Contributor

Also, fixed another instance of a bad LLNL link.

The verbiage adjustment is due to this comment from @qkoziol.

Also, fixed another instance of a bad llnl link
The filter identifier is designed to be a unique identifier for the filter. Values from `zero` through `32,767` are reserved for filters supported by The HDF Group in the HDF5 library and for filters requested and supported by the 3rd party.
The filter identifier is designed to be a unique identifier for the filter.
Values from `0` to `255` are reserved for internal use by The HDF Group for filters that are part of the HDF5 library itself.
Values from `256` through `32,767` are reserved for filters *managed* by The HDF Group but nominally requested, developed and supported by 3rd parties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values from 256 to 511 are available for testing new VOL connectors. Values from 512 to 32,767 are reserved for filters managed by The HDF Group but are nominally requested, developed, and supported by third parties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brtnfld I just updated as you specified.

FYI, are you familiar with making a "suggestion" (read through there to around step 7) via GitHub GUI here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. It has been some time since I've used "suggestions," but that would likely make things easier.

The filter identifier is designed to be a unique identifier for the filter. Values from `zero` through `32,767` are reserved for filters supported by The HDF Group in the HDF5 library and for filters requested and supported by the 3rd party.
The filter identifier is designed to be a unique identifier for the filter.
Values from `0` to `255` are reserved for internal use by The HDF Group for filters that are part of the HDF5 library itself.
Values from `256` to `511` are available for testing new VOL connectors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is about filter plugins, not VOL connectors.

Copy link
Contributor

@brtnfld brtnfld Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, I apologize for my mistake; I have had the VOLs on my mind lately. Here is what we state in the Doxygen documentation if you would like to use the same wording:

Values from zero through 32,767 are reserved for filters supported by The HDF Group in the HDF5 library and for filters requested and supported by 3rd parties. Values from 32768 to 65535 are reserved for non-distributed uses (e.g., internal company usage) or application usage when testing a feature.

@lrknox lrknox merged commit 0bf1aee into HDFGroup:master Nov 22, 2024
8 checks passed
lrknox added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants