Bring subfiling VFD code closer to typical library code #4595

qkoziol · 2024-06-21T05:06:08Z

Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros, rename functions to have more standardized names, etc.

Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros, rename functions to have more standardized names, etc. Signed-off-by: Quincey Koziol <[email protected]>

qkoziol · 2024-06-21T05:13:40Z

This PR addresses the issues in the subfiling code from the "pause_errors" PR, #4475

Signed-off-by: Quincey Koziol <[email protected]>

src/H5FDsubfiling/H5FDioc_threads.c

Signed-off-by: Quincey Koziol <[email protected]>

src/H5FDsubfiling/H5FDsubfiling.c

src/H5FDsubfiling/H5FDioc.c

Signed-off-by: Quincey Koziol <[email protected]>

src/H5FDsubfiling/H5FDsubfiling.c

Signed-off-by: Quincey Koziol <[email protected]>

src/H5FDsubfiling/H5subfiling_common.c

Signed-off-by: Quincey Koziol <[email protected]>

qkoziol · 2024-06-24T21:02:30Z

@jhendersonHDF @derobins - Could you please review? I'd like to get this merged, so I can return to debugging the performance regression in the subfiling code.

…rom_vfds

jhendersonHDF · 2024-06-26T01:33:35Z

src/H5FDsubfiling/H5subfiling_common.c

-        if (H5_mpi_comm_free(&node_comm) < 0)
-            H5_SUBFILING_DONE_ERROR(H5E_VFL, H5E_CANTFREE, FAIL, "couldn't free MPI communicator");
+        if (node_comm != MPI_COMM_NULL)
+            if (H5_mpi_comm_free(&node_comm) < 0)


Not a big deal at all, but H5_mpi_comm_free already checks for MPI_COMM_NULL and MPI_COMM_WORLD, which is why the code previously just called the function for simplicity.

Ah, missed that, thanks. Fixed now.

jhendersonHDF

Generally looks good now, though the significant amount of cleanup and other mostly-unrelated changes definitely made this a decent bit harder to review

Signed-off-by: Quincey Koziol <[email protected]>

Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros, rename functions to have more standardized names, etc.

* Fix typos in context/property documentation (#4550) * Fix CI markdown link check http 500 errors (#4556) Sites like GitLab can have internal problems that return http 500 errors while they fix their problems. Some sites also return http 200 OK, which is fine. This PR adds a config file to the markdown link check so those are considered "passing" and don't break the CI. * Simplify property copying between lists internally (#4551) * Add Python examples (#4546) These examples are referred to from the replacement page of https://portal.hdfgroup.org/display/HDF5/Other+Examples. * Correct property cb signatures in docs (#4554) * Correct property cb signatures in docs * Correct delete callback type name in docs * add missing word to H5P__free_prop doc * Move C++ and Fortran and examples to HDF5Examples folder (#4552) * Document 'return-and-read' field in API context (#4560) * Add compression includes to tests needing zlib support (#4561) * Allow usage of page buffering for serial file access from parallel HDF5 builds (#4568) * Remove old version of libaec (#4567) * Add property names to context field docs (#4563) * Document property shared name behavior (#4565) * Clarify H5CX macro documentation (#4569) * Document H5Punregister modifying default properties (#4570) * Update NVHPC to 24.5 (#4171) We don't test parallel in other GitHub actions, so this also converts the NVHPC check to configure and build only while we discuss how we'll test parallel HDF5 in GitHub. There is a blocking GitHub issue to address the test failures for HDF5 1.14.5 (#4571). * Clean up comments in H5FDros3.c (#4572) * Rename INSTALL_Auto.txt to INSTALL_Autotools.txt (#4575) * Clean up ros3 VFD stats code (#4579) * Removes printf debugging * Simplifies and centralizes stats code * Use #ifdef ROS3_STATS instead of #if * Other misc tidying * Turn off ros3 VFD stat collection by default (#4581) Not a new change - an artifact from a previous check-in. * Pause recording errors instead of clearing the error stack (#4475) An internal capability that's similar to the H5E_BEGIN_TRY / H5E_END_TRY macros in H5Epublic.h, but more efficient since we can avoid pushing errors on the stack entirely (and those macros use public API routines). This capability (and other techniques) can be used to remove use of H5E_clear_stack() and H5E_BEGIN_TRY / H5E_END_TRY within library routines. We want to remove H5E_clear_stack() because it can trigger calls to the H5I interface from within the H5E code, which creates a great deal of complexity for threadsafe code. And we want to remove H5E_BEGIN_TRY / H5E_END_TRY's because they make public API calls from within the library code. Also some other minor tidying in routines related to removing the use of H5E_clear_stack() and H5E_BEGIN_TRY / H5E_END_TRY from H5Fint.c * Add page buffer cache command line option to tools (#4562) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Clarify documentation for H5CX_get_data_transform (#4580) * Correct comment for H5CX_get_data_transform * Document why data transform ctx field doesnt use macro * Remove public API call from ros3 VFD (#4583) * Remove printf debugging from H5FDs3comms.c (#4584) * Cleanup of ros3 test (#4587) * Removed JS* macro scheme (replaced w/ h5test.h macros) * Moved curl setup/teardown to main() * A lot of cleanup and simplification * Removed unused code from H5FDs3comms.c (#4588) * H5FD_s3comms_nlowercase() * H5FD_s3comms_trim() * H5FD_s3comms_uriencode() * Remove magic fields from s3comms structs (#4589) * Remove dead H5FD_s3comms_percent_encode_char() (#4591) * Rework the TestExpress usage and refactor dead code (#4590) * Skip examples if running sanitizers (#4592) * Clean up s3comms test code (#4594) * Remove JS* macros * Remove dead code * Bring in line with other test code * Add publish to bucket workflow (#4566) * Update abi report CI workflow for last release (#4596) * Update abi report workflow to handle 1.14.4.3 release * Update name of java report * Document that ctx VOL property isn't drawn from the FAPL (#4597) * Update macos workflow to 14 (keep 13 as alternate) (#4603) * Removed unnecessary call to H5E_clear_stack (#4607) H5FO_opened and H5SL_search don't push errors on the stack * Bring subfiling VFD code closer to typical library code (#4595) Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros, rename functions to have more standardized names, etc. * Correct documentation for return-and-read fields (#4598) * These two generators create strings without NUL for testing (#4608) * Fix Fortran pkconfig to indicate full path of modules (#4593) * Updated release schedule (#4615) 1.16 and 2.0 information * Document VOL object wrapping context (#4611) * Earray.c and farray.c in hdf5_1_14 still need time_t curr_time for HDsrandom. * Remove line to use future 116_API from CMakeListat.txt files in HDF5 examples directories

Bring subfiling VFD code closer to typical library code

75d8c26

Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros, rename functions to have more standardized names, etc. Signed-off-by: Quincey Koziol <[email protected]>

qkoziol requested review from lrknox, derobins, byrnHDF, fortnern, jhendersonHDF, vchoi-hdfgroup, bmribler, glennsong09, mattjala and brtnfld as code owners June 21, 2024 05:06

qkoziol mentioned this pull request Jun 21, 2024

Refactor threading and other concurrency support #4469

Merged

Committing clang-format changes

006a21c

qkoziol added 2 commits June 21, 2024 00:19

Clean up warnings

b36cb5a

Signed-off-by: Quincey Koziol <[email protected]>

Remove unused function prototype

81253f4

Signed-off-by: Quincey Koziol <[email protected]>

hyoklee approved these changes Jun 21, 2024

View reviewed changes

derobins added Merge - To 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality labels Jun 21, 2024