Skip to content

Commit

Permalink
Bring subfiling VFD code closer to typical library code (#4595)
Browse files Browse the repository at this point in the history
Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros,
rename functions to have more standardized names, etc.
  • Loading branch information
qkoziol authored Jun 27, 2024
1 parent 59f010e commit 81a563f
Show file tree
Hide file tree
Showing 10 changed files with 2,596 additions and 3,742 deletions.
1,032 changes: 373 additions & 659 deletions src/H5FDsubfiling/H5FDioc.c

Large diffs are not rendered by default.

249 changes: 106 additions & 143 deletions src/H5FDsubfiling/H5FDioc_int.c

Large diffs are not rendered by default.

19 changes: 7 additions & 12 deletions src/H5FDsubfiling/H5FDioc_priv.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "H5Pprivate.h" /* Property lists */

#include "H5subfiling_common.h"
#include "H5subfiling_err.h"

#include "mercury_thread.h"
#include "mercury_thread_mutex.h"
Expand Down Expand Up @@ -411,17 +410,13 @@ extern int *H5FD_IOC_tag_ub_val_ptr;
extern "C" {
#endif

H5_DLL int initialize_ioc_threads(void *_sf_context);
H5_DLL int finalize_ioc_threads(void *_sf_context);

H5_DLL herr_t ioc__write_independent_async(int64_t context_id, int64_t offset, int64_t elements,
const void *data, io_req_t **io_req);
H5_DLL herr_t ioc__read_independent_async(int64_t context_id, int64_t offset, int64_t elements, void *data,
io_req_t **io_req);

H5_DLL herr_t ioc__async_completion(MPI_Request *mpi_reqs, size_t num_reqs);

H5_DLL int wait_for_thread_main(void);
H5_DLL herr_t H5FD__ioc_init_threads(void *_sf_context);
H5_DLL herr_t H5FD__ioc_finalize_threads(void *_sf_context);
H5_DLL herr_t H5FD__ioc_write_independent_async(int64_t context_id, int64_t offset, int64_t elements,
const void *data, io_req_t **io_req);
H5_DLL herr_t H5FD__ioc_read_independent_async(int64_t context_id, int64_t offset, int64_t elements,
void *data, io_req_t **io_req);
H5_DLL herr_t H5FD__ioc_async_completion(MPI_Request *mpi_reqs, size_t num_reqs);

#ifdef __cplusplus
}
Expand Down
Loading

0 comments on commit 81a563f

Please sign in to comment.