Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HTTP 301/302 not work with AwsStreamHandler #204

Closed
wants to merge 1 commit into from
Closed

fix HTTP 301/302 not work with AwsStreamHandler #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/handlers/aws/aws-stream.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export class AwsStreamHandler<TApp> extends BaseHandler<
// so I have this thing just to fix this issue
// ref: https://stackoverflow.com/a/37303151
const isHundreadStatus = status >= 100 && status < 200;
const isNoContentStatus = status === 304 || status === 204;
const isNoContentStatus = status >= 300 && status < 400;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isNoContentStatus = status >= 300 && status < 400;
const isNoContentStatus = (status >= 300 && status < 400) || status === 204;

const isHeadRequest = requestValues.method === 'HEAD';

if (isHundreadStatus || isNoContentStatus || isHeadRequest) {
Expand Down