fix HTTP 301/302 not work with AwsStreamHandler #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H4ad
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Did you had issue while integrating with AWS Stream Response with these status? Because from what I remember, in the past when I tested, I didn't had issues.
Also, can you please change your commit message to be: fix(aws): HTTP 301/302 not work with AwsStreamHandler
| @@ -301,7 +301,7 @@ export class AwsStreamHandler<TApp> extends BaseHandler< | |||
| // so I have this thing just to fix this issue | |||
| // ref: https://stackoverflow.com/a/37303151 | |||
| const isHundreadStatus = status >= 100 && status < 200; | |||
| const isNoContentStatus = status === 304 || status === 204; | |||
| const isNoContentStatus = status >= 300 && status < 400; | |||
There was a problem hiding this comment.
Suggested change
| const isNoContentStatus = status >= 300 && status < 400; | |
| const isNoContentStatus = (status >= 300 && status < 400) || status === 204; |
|
I created another PR to address this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
300 Multiple Choices
301 Moved Permanently
302 Found
303 See Other
304 Not Modified
307 Temporary Redirect
308 Permanent Redirect
I believe these HTTP code should have no body as well.
Or at least make 301/302 in the list, otherwise we cannot send 301/302 redirect with AwsStreamHandler.