Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux constants. stage1. methods #448

Open
atherdon opened this issue Jun 28, 2019 · 26 comments
Open

redux constants. stage1. methods #448

atherdon opened this issue Jun 28, 2019 · 26 comments
Assignees

Comments

@atherdon
Copy link
Member

Is your feature request related to a problem? Please describe.
@AkshayChoulwar Sorry for short description, let's explore this task at comments. feel free and ask me anything

right now here we have 2 files that will give you an idea of what we need to do.

  1. check this file https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md we'll use information from it in order to create 50-70 constants before moving to a next stage
  2. this is an example of how methods of groceristar - departments entity looks as constants: https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/const-departments-example.js

Is it was created as task at GitHub issues? Please provide an issue number or link

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@atherdon
Copy link
Member Author

atherdon commented Jun 28, 2019

You may ask me - how departments file was created?
This is an actual task for those departments:


"By using names on methods from this page we created a set of constants.
Each constant is just a human version of the method that we have. But we didn't finish work, related to department methods. You'll need to do it.

Example:
Get data, related to single department
equal to export const GET_DEPARTMENT_DATA = "GET_DEPARTMENT_DATA";

  • you need to move your file at Groceristar folder(decide where exactly it should be - or discuss with me)
  • rename this file, because it's not very clear name.
  • we need it as JS file

"

@atherdon
Copy link
Member Author

youre first assesment to this task will be:

By using names on methods from this page
In order to make it better, we'll create set of constants, each for a different method.

Example:
Create or find at db new ingredient new ingredient and attach it to grocery list
will became export const FIND_OR_CREATE_AND_ATTACH_TO_GROCERY = "FIND_OR_CREATE_AND_ATTACH_TO_GROCERY";

@atherdon
Copy link
Member Author

atherdon commented Jun 30, 2019

[Completed]
@elnur004 you can grab this one

By using names on methods from this page
In order to make it better, we'll create a set of constants, each for a different method.

Example:
Get All ingredients with status favorite
will became export const GET_ALL_FAVORITE_INGREDIENTS = "GET_ALL_FAVORITE_INGREDIENTS ";

GroceriStar/fetch-constants#3

@atherdon
Copy link
Member Author

@elnur004 another one for you

By using names on methods from this page
In order to make it better, we'll create set of constants, each for a different method.

Example:
Method that will Display Grocery List Data
will became export const GET_FULL_GROCERY_LIST = "GET_FULL_GROCERY_LIST";


@atherdon atherdon mentioned this issue Jun 30, 2019
14 tasks
@atherdon
Copy link
Member Author

@elnur004 similar to previous one, but will require some time for research

https://chickenkyiv.github.io/search-api-documentation/docs/db-schema

https://chickenkyiv.github.io/search-api-documentation/docs/db-schema
By using names on URLS from this page
In order to make it better, we'll create set of constants, each for a different method.

Example:
http://localhost:3000/api/attribute?filter[where][type]=allergy
will became export const ATTRIBUTE_FILTER_TYPE_ALLERGY = "ATTRIBUTE_FILTER_TYPE_ALLERGY";

@atherdon atherdon mentioned this issue Jul 1, 2019
14 tasks
@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2019

@elnur004 same thing, but step2

https://chickenkyiv.github.io/search-api-documentation/docs/db-schema

https://chickenkyiv.github.io/search-api-documentation/docs/db-schema
By using names on URLS from this page
In order to make it better, we'll create set of constants, each for a different method.

Example:
http://localhost:3000/api/attribute?filter[where][type]=allergy
will became export const ATTRIBUTE_FILTER_TYPE_ALLERGY = "ATTRIBUTE_FILTER_TYPE_ALLERGY";

@atherdon atherdon mentioned this issue Jul 1, 2019
14 tasks
@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2019

@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2019

@siddharthp538 you can grab this part of data. https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md#models-1
this part is similar to work that was done before here

@elnur004
Copy link

elnur004 commented Jul 1, 2019

@atherdon in which file we need to create constants for models? create new files or how?

@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2019 via email

@atherdon
Copy link
Member Author

atherdon commented Jul 5, 2019

@elnur004 you should continue to work on this task. I think at this file https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md we have a lot of work to do

@AkshayChoulwar
Copy link

Hi @atherdon,

There is an existing depatment.js file under the docs directory, my question is which constants should have to add on that file because I am seeing some constants in that already.

@atherdon
Copy link
Member Author

atherdon commented Jul 6, 2019

@AkshayChoulwar this was your first task: #448 (comment)
departments was just an example, that shows how this task should be done: #448 (comment)

@atherdon
Copy link
Member Author

atherdon commented Jul 6, 2019

but, as you already checking departments - tell me - do all of the methods were transferred? we didn't miss anything?

@AkshayChoulwar
Copy link

@atherdon according to this page for departments it's completed.

@AkshayChoulwar
Copy link

@atherdon for this task whether we have to create the separate file or should we add to the ingredient.js file.

@atherdon
Copy link
Member Author

atherdon commented Jul 7, 2019 via email

@AkshayChoulwar
Copy link

@atherdon thanks for clearing doubts.

@atherdon
Copy link
Member Author

@elnur004 do we have something left here for you?

@elnur004
Copy link

@atherdon i guess we've done all constants and models

@elnur004
Copy link

@atherdon if this task has been done already, may i get a new one, please?

@atherdon
Copy link
Member Author

all things from this file: https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md? i just not remember what exactly we were working on :) give me more details so I can refresh my memory.

if we finish it - then yeah - i'll find a new task for you

@elnur004
Copy link

elnur004 commented Jul 11, 2019

we just created several constants and model files.

@atherdon
Copy link
Member Author

so we can do other sections from this file? if yes - then you can jump into it. i'm a bit busy right now - soon will find something more interesting to you

@elnur004
Copy link

@atherdon need we create constants related to relations for model schemas?

@atherdon
Copy link
Member Author

atherdon commented Jul 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants