Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an index files inside of examples folder and connect all of our examples/schemas there #516

Open
atherdon opened this issue Jun 12, 2019 · 11 comments

Comments

@atherdon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to splify our work with next step - we can reduce logic of connecting schemas and examples by having one file that connect all of them.
later we'll create a method, that will return both schema and example into our test file.
it maybe not make our code better, but will help us later

Is it was created as task at GitHub issues? Please provide an issue number or link

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@atherdon atherdon added this to the Testing & Tests milestone Jun 14, 2019
atherdon added a commit that referenced this issue Jun 17, 2019
created index file & connected with schema/example #516
@atherdon
Copy link
Contributor Author

Ok, let's also add and export from this file a method, that will return to us one files, when it's necessary. something like get('allergy') and it will return our variable

@elnur004
Copy link
Contributor

what do you recommend? how to do this?

@atherdon
Copy link
Contributor Author

atherdon commented Jun 18, 2019 via email

@elnur004
Copy link
Contributor

@atherdon need we add a function in index.js file or play.js one for return the file with data?

@elnur004
Copy link
Contributor

btw sorry for the late response. i've been busy lately

@atherdon
Copy link
Contributor Author

atherdon commented Jun 26, 2019 via email

@elnur004
Copy link
Contributor

@atherdon @vadim9999 is there any task for me?

@atherdon
Copy link
Contributor Author

of course! @elnur004
did you remember our initial task, related to creating constants? I think now you can crack it without any problems. i move that task into fetch plugin, if you want - i'll assign it to you

@elnur004
Copy link
Contributor

@atherdon yeah i'm waiting!

@atherdon
Copy link
Contributor Author

@elnur004 grab this one: GroceriStar/groceristar-fetch#448 (comment)

Am i rihgt - i can close this task?

@elnur004
Copy link
Contributor

@atherdon if everything has been done, you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants