Don't tick the preview world from updateFormedValid #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syrcan
approved these changes
Feb 22, 2022
ChromaPIE
added a commit
to ChromaPIE/GregTech
that referenced
this pull request
Feb 22, 2022
* Grab default meta when meta exceeds allowed values for meta blocks (GregTechCEu#621) - Prevents world corrupting crash * Logic hacking for certain contexts to abide to the correct StoneType (GregTechCEu#638) * Rework Metafluids (GregTechCEu#542) * rework metafluids * add acid type to acids * improve ct fluid validation * material getter * some ct support * fluid state tooltip for each FluidType * requested changes * fix wrong fluid names * fix FluidTooltipUtil method * fix all fluid tooltips * UU matter tooltip * explicitly block plasmas in the fluid CT method * fix plasma unlocalized names * make fluid tooltips smart * fix custom acid material textures * fix vanilla fluid tooltips * fix failing tests * fix tooltip and ct error logging * undo test "fix" * more review comments * change maps * stop using lowercase * use computeIfAbsent * fix empty tooltips on items * stop trying to register all fluids twice and fix temperatures * Minor recipe and formula fixes (GregTechCEu#624) * dimethylbenzene and 3,3-dichlorobenzidine ratio fixes * fix IV Coil voltage * disable Nitrobenzene decomposition to prevent dupes * fix Butene formula * fix Ethenone and Methyl Acetate formula * fix Vinyl Acetate formula * fix Monochloramine and Allyl Chloride formula * fix Allyl Chloride properties * Make sugar C6H12O6, like an actual carbohydrate * fix Liquid Air formula Co-authored-by: bruberu <[email protected]> * Fix `drawFluidForGui` drawing incorrectly for some mods * Fix fluid prospector crash on servers (GregTechCEu#676) * fix problems with chanced outputs in jei (GregTechCEu#675) * Maintenance fix (GregTechCEu#677) * Fix muffler particles having little pos variation * Polycaprolactam processing revamp (GregTechCEu#600) * Polycaprolactam chain * Use Blast Furnace instead * Address review comments * Fix problems (again) * Update and use FluidTypes * Third time's the charm? * Change which event blocks were created in (GregTechCEu#535) * Allow Robot Arms to Supply Exact more than 1 stack (GregTechCEu#635) * Don't tick the preview world from updateFormedValid (GregTechCEu#608) * UTF-8 (GregTechCEu#678) Co-authored-by: Rongmario <[email protected]> Co-authored-by: TechLord22 <[email protected]> Co-authored-by: m2r1k5 <[email protected]> Co-authored-by: bruberu <[email protected]> Co-authored-by: DStrand1 <[email protected]> Co-authored-by: Syrcan <[email protected]> Co-authored-by: ALongStringOfNumbers <[email protected]> Co-authored-by: KilaBash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Don't call
updateFormedValidif the world is the JEI preview world.When launching the game with a debug breakpoint in ARL#trySearchNewRecipe, I noticed that the breakpoint would get hit several times before loading the game finished, by the PBF, Coke Oven, Fusion Reactor, and Steam Multiblocks specifically.
I have therefore added a check that we are not in the JEI preview world before ticking
updateFormedValid.The check cannot be at the main
ifstatement, where it is checkedif(!getWorld.isRemote())as we still need to callcheckStructurePatternso that the multiblocks are formed in the JEI previews.