Zero initial EUt of multiplied parallel logic #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAGIdiot
reviewed
Jan 22, 2023
LAGIdiot
approved these changes
Jan 24, 2023
|
We do something similar down below in the AppendItems method, although there we also clear the duration, as some recipes have pre-determined durations as well. So I am trying to think if we also need to clear the duration here. We should also try and update the tests to catch this error |
ALongStringOfNumbers
approved these changes
Jan 25, 2023
ghzdude
pushed a commit
to ghzdude/GregTechCEu
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As in #1120, parallel logic sometimes has an initial EUt in its copied recipe map, which results in higher energy consumption than intended.
Implementation Details
Ensure that the EUt of the copied recipe map is 0.
Outcome
Washing/macerating 2 ores will not consume the energy cost of 3 recipes.
Fixes (properly): GregTechCEu/gregicality-multiblocks#19