Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

States motion planner -> superstructure #31

Open
wants to merge 18 commits into
base: core
Choose a base branch
from
Open

States motion planner -> superstructure #31

wants to merge 18 commits into from

Conversation

maya1414
Copy link

No description provided.

@drorta drorta changed the title States motion planner States motion planner -> superstructure Oct 17, 2024
tnrz135
tnrz135 previously approved these changes Oct 17, 2024
View reviewed changes
YoniKiriaty
YoniKiriaty previously approved these changes Oct 17, 2024
View reviewed changes
@maya1414 maya1414 requested a review from YHerm October 17, 2024 13:54
drorta
drorta requested changes Oct 18, 2024
View reviewed changes
Copy link

@drorta drorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not using the state motion planner in pre Amp, Amp, the transfers and the outtakes

src/main/java/frc/robot/superstructure/StatesMotionPlanner.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/superstructure/Superstructure.java Outdated Show resolved Hide resolved
@maya1414 maya1414 requested a review from drorta October 18, 2024 13:43
@maya1414 maya1414 requested a review from drorta October 18, 2024 18:28
@maya1414 maya1414 requested a review from drorta October 18, 2024 19:02
@maya1414 maya1414 requested a review from hillelv October 18, 2024 20:54
@maya1414 maya1414 requested a review from hillelv October 19, 2024 08:58
@maya1414 maya1414 requested a review from drorta October 19, 2024 09:43
drorta
drorta previously approved these changes Oct 19, 2024
View reviewed changes
Base automatically changed from superstructure to core October 19, 2024 20:24
@YHerm YHerm dismissed stale reviews from drorta, bossyshrimp68, YoniKiriaty, and tnrz135 October 19, 2024 20:24

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoniKiriaty YoniKiriaty YoniKiriaty left review comments

@drorta drorta drorta left review comments

@bossyshrimp68 bossyshrimp68 bossyshrimp68 left review comments

@tnrz135 tnrz135 tnrz135 left review comments

@YHerm YHerm Awaiting requested review from YHerm

@hillelv hillelv Awaiting requested review from hillelv

@greenblitz4590 greenblitz4590 Awaiting requested review from greenblitz4590

Requested changes must be addressed to merge this pull request.

Assignees

@maya1414 maya1414

Labels
A-SMALL-PR needs-robot-testing needs-simulation-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maya1414 @tnrz135 @greenblitz4590 @bossyshrimp68 @drorta @YoniKiriaty @YHerm @hillelv