-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update If-check to support CI/CD #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm!
@manushak @jmcook1186 it works but we have a bug and there is suggestion for improvement. Right now we are getting the following:
Which means after summary we are getting logs |
As an improvement to UI we can modify messages like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments above
ok I like the proposed updates but also liked that @manushak 's version separated out the individual emitted logs from the summary of failures. think we need some kind of break between the emitted messages and the "summary" - even if it is just a line break and
|
@jmcook1186 it doesn't look like an intentional solution since the title is before the summary and the rest is after. Yeah the end solution looks good |
Types of changes
A description of the changes proposed in the Pull Request