Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update if-check to support CI/CD #870

Closed
2 tasks done
zanete opened this issue Jul 1, 2024 · 0 comments · Fixed by #872
Closed
2 tasks done

Update if-check to support CI/CD #870

zanete opened this issue Jul 1, 2024 · 0 comments · Fixed by #872
Assignees

Comments

@zanete
Copy link

zanete commented Jul 1, 2024

What

Update if-check so that it exits with a failure response if any of the files it is checking fail to validate.

Context

We cannot currently distinguish between if-check -d runs that have failing manifests from runs with all passing manifests without manually examining the logs. This means we can;t easily ac ton the responses when we use if-check to drive our automated testing in CI/CD.

SoW

  • update if-check so it exits with an error code (1) after running if-check over all manifests in a folder

Acceptance criteria

  • if-check exits with an appropriate error code

GIVEN all manifests in my-folder are correct
WHEN I run if-check -d my-folder
THEN I see a series of logs:

Files match!

and the exit code is 0

GIVEN some manifests are incorrect
WHEN I run if-check -d my-folder
THEN I should see logs similar to

Files match!

Files match!

Files do not match!

Files match!

And if-check should exit with error code 1

@zanete zanete added this to IF Jul 1, 2024
@zanete zanete converted this from a draft issue Jul 1, 2024
@zanete zanete assigned zanete and jmcook1186 and unassigned zanete Jul 1, 2024
@zanete zanete moved this from In Progress to In Design in IF Jul 1, 2024
@manushak manushak moved this from In Design to Pending Review in IF Jul 2, 2024
@manushak manushak linked a pull request Jul 2, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Pending Review to Done in IF Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants