Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate multiply plugin to builtins #709

Merged
merged 17 commits into from
May 22, 2024
Merged

Migrate multiply plugin to builtins #709

merged 17 commits into from
May 22, 2024

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Migrates Multiply plugin into IF builtins.
Addresses #679

@jmcook1186 jmcook1186 self-assigned this May 10, 2024
@jmcook1186 jmcook1186 changed the title Migrate multiply plugin to builtins Migrate multiply plugin to builtins May 10, 2024
@jmcook1186 jmcook1186 mentioned this pull request May 16, 2024
Open
narekhovhannisyan
narekhovhannisyan reviewed May 22, 2024
View reviewed changes
src/builtins/multiply/README.md
To run the plugin, you must first create an instance of `Multiply`. Then, you can call `execute()`.

```typescript
import {Multiply} from 'builtins';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this part for builtin plugins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so... ?

@jmcook1186 jmcook1186 merged commit 6ff5790 into main May 22, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the migrate-multiply-plugin branch May 22, 2024 09:00
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@manushak manushak manushak approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees

@jmcook1186 jmcook1186

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcook1186 @manushak @narekhovhannisyan