Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the divide plugin into builtins #647

Merged
merged 13 commits into from
May 24, 2024
Merged

Move the divide plugin into builtins #647

merged 13 commits into from
May 24, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Move the sum plugin from if-plugins into IF builtins
  • update the manifest file

@manushak manushak self-assigned this Apr 18, 2024
@jmcook1186 jmcook1186 mentioned this pull request May 16, 2024
Open
@zanete zanete mentioned this pull request May 20, 2024
Closed
2 tasks
@jmcook1186
Copy link
Contributor

@jmcook1186 to review

@manushak manushak linked an issue May 23, 2024 that may be closed by this pull request
Move Divide to if/builtins #676
Closed
2 tasks
jmcook1186
jmcook1186 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated import paths in manifests
now sgtm

@jmcook1186 jmcook1186 merged commit 0b8434c into main May 24, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the move-divide branch May 24, 2024 15:33
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan narekhovhannisyan left review comments

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Divide to if/builtins
4 participants
@manushak @jmcook1186 @narekhovhannisyan @MariamKhalatova