-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Plug-in Registry #684
Comments
@jawache @jmcook1186 do you have any suggestions / vision on the behaviour of Tags - are they clickable? if so, does it filter the plugins by that tag? |
i definitely think we should support a finite set of predefined tags. I don't have a list of what those tags should be yet. |
My suggestion right now is to make the tags something indexed at least, so if you search for a term and it's in a tag for a plugin, then that's a match. I'm less bothered about making tags clickable for this MVP we'll have a couple of dozen plugins for now, if it doesn't add much time I'm not against the idea but if it's multiple days it's not that important imo. @jmcook1186 agreed we should have some suggested tag names in the docs but also allow flexibility for them to tag as they like, we can't really guess the universe of useful tags at the moment. |
Thanks @jawache and @jmcook1186 , I would suggest to leave it free for the MVP and then if we start getting stuff that means same thing but described by many different tags such as @osamajandali do you have a comment for how much effort is extra if tags
|
Website is ready and I'm currently waiting for the data. Tags are indexed, and users can filter by them, so we are in good shape now. There are a few tweaks remaining that need to happen after the data is in. Do we want people to filter with multiple tags or just one tag at a time? If we need multiple tags, we should list all tags in the aside section so people can easily know what filters being applied. |
For now, we can just have one tag filtering at a time due to the low number of plugins at launch. |
I think the json data for each card could be as simple as this (I used a real plugin I made as an example):
|
Hey @osamajandali when you click on the card does it take you to one place right (npm or github if no npm or website if no github - I believe that was the functionality from the Gulp version)? Or is clicking on different parts of the card going to take people to different places? @jmcook1186 we also need the tags and I think some flag to indicate it's an official plugin (one of our's) maybe a badge for hackathon winner? So something like this?
|
Oh and should we also insist they have their email address in author, something they are willing to share publicly, we may need to contact them in the future? |
ok - do we really want to support an I saw badges less for affiliation and more for achievements, like "100% test coverage", "great docs", "literature support", "hackathon winner" or similar (and that we would implement those later). We can request an email I suppose - comes with some doxxing risks that not everyone will be comfortable with. Make it optional? |
@jmcook1186 so I think we should list all our plugins here, doesn't really matter if they are builtins or not. Would be confusing to ask people to look in two places for the total list of things you can put in plugins. One stop shop to find the right plugin for your manifest. For badges, the UI just supports one badge per card (I assumed at least), we can maybe have an editors pick badge then to recognize the plugins that have gone the extra mile with good testing, docs etc... I think it's ok to insist on an email address, they can create a special one just for us or something from proton mail? Just some way we can contact them if there is a problem with their plugin, you can't DM people with just GitHub username :/ or at least list something where there is a way for us to DM them, twitter/linkedin/email? |
ok fair enough! |
Thank you, @jmcook1186, for the JSON format. @jawache, the entire card will not be clickable due to the nested links, allowing each part to be clickable as necessary. Regarding the email section, should it be included in the same JSON or perhaps in a separate file, like an .md file? |
@osamajandali I'm going to try to get an excel file to you later today with a set of plugins ready for launch day - we'll probably have to iterate on it a few times as we are in the process of migrating some of our plugins between repos. |
That would be cool, it's is always better to have some data from the beginning so that I can eliminate any possible bugs. |
@jmcook1186 can you share the link to docs on How to submit a plugin and where people can find the form currently? We need that for the button at the top |
Here's the tutorial page I think the webpage could just have a clear link ( |
|
@manushak can you share the approach you used in your integrations to automate the rebuild of the site upon data change in notion 🙏 |
To integrate the Notion database into the website, first, we need to create a Notion built-in integration. This has been done in the Notion <> Google Group integration. To automatically fetch data from the database, we can set up a CI/CD job to update every, let's say, 24 hours, which I have already done. @osamajandali, we can have a call, and I'll guide you step by step |
thanks so much @manushak - for @osamajandali, please only follow this if it is easier than the solution we agreed, as the goal is still to create the simplest solution to implement regardless of user experience. |
@osamajandali @zanete @jawache PLEASE BE ADVISED THAT IF YOU RUN CODE INCLUDED IN THESE PLUGINS OR USE INFORMATION GENERATED BY THESE PLUGINS, INCLUDING MAKING ANY DECISIONS BASED UPON THE INFORMATION, YOU DO SO AT YOUR OWN RISK. GREEN SOFTWARE FOUNDATION MAKES NO REPRESENTATION, GUARANTEE OR WARRANTY, EXPRESS OR IMPLIED, STATUTORY OR OTHERWISE, INCLUDING MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE NOR ANY WARRANTIES ARISING FROM COURSE OF PERFORMANCE, COURSE OF DEALING OR USAGE IN TRADE. |
Also @zanete @osamajandali when we gop live can we use the following URL |
Things to implement in the form / notion:
Expected next revision before the weekend |
All updates needed are done and it's ready to be deployed. Please take a look and let me know when to go live |
Looks great @osamajandali I think we also need the disclaimer to be on the landing page, in capitals, near the top maybe as a banner or with the text under the page title. |
@osamajandali also, are the tags searchable? when I search for "food" nothing comes up (but it is a tag) |
@jmcook1186 If we need it more visible, I'll move it to the top. @zanete I found a good way to filter by clicking on the tag instead of using the search bar, as we agreed. Now, you can search with any term, and it will be filtered by the selected tag. |
@osamajandali thanks for the clarification, it would make sense that searching for a tag value brings up anything that is tagged with it, so how much effort is it to make tags searchable, too? |
@osamajandali thank you, works great! Let's deploy https://explorer.if.greensoftware.foundation/ |
I've add searching with tag in the search field The website is deployed https://explorer.if.greensoftware.foundation/ Keep in mind that the data is being fetched from notion automatically every 6 hours but if you want to trigger instant update do the following:
|
Hey @osamajandali, can we have the title of the card also clickable? That feels like the expected user experience, it's hard to know that the npm and GH links are what you are supposed to click. I keep on clicking the title expecting it to take me somewhere. The logic should be it takes you to npm and if that doesn't exist then to the GitHub. |
this will be completed this week |
All fixes remaining are address now, please check it out! |
Why: Sub of #633
What: Implement the Plugin Registry website
Scope of work:
PLEASE BE ADVISED THAT IF YOU RUN CODE INCLUDED IN THESE PLUGINS OR USE INFORMATION GENERATED BY THESE PLUGINS, INCLUDING MAKING ANY DECISIONS BASED UPON THE INFORMATION, YOU DO SO AT YOUR OWN RISK. GREEN SOFTWARE FOUNDATION MAKES NO REPRESENTATION, GUARANTEE OR WARRANTY, EXPRESS OR IMPLIED, STATUTORY OR OTHERWISE, INCLUDING MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE NOR ANY WARRANTIES ARISING FROM COURSE OF PERFORMANCE, COURSE OF DEALING OR USAGE IN TRADE.
https://explorer.if.greensoftware.foundation/
The text was updated successfully, but these errors were encountered: