Sidecar collector rename #4903
Sidecar collector rename #4903
Conversation
| @@ -38,8 +40,13 @@ class SidecarStatusPage extends React.Component { | |||
| SidecarsActions.getSidecar(this.props.params.sidecarId).then(sidecar => this.setState({ sidecar })); | |||
| }; | |||
|
|
|||
| reloadCollectors() { | |||
There was a problem hiding this comment.
As this is an ES6 class, this should use an arrow function, to ensure this is properly bound, even if the function calling it is not autobound by React.
From https://reactjs.org/docs/react-without-es6.html#autobinding:
If you’d rather play it safe, you have a few options:
- Bind methods in the constructor.
- Use arrow functions, e.g.
onClick={(e) => this.handleClick(e)}.- Keep using
createReactClass.
| @@ -9,6 +9,7 @@ import SidecarStatusFileList from './SidecarStatusFileList'; | |||
| const SidecarStatus = createReactClass({ | |||
| propTypes: { | |||
| sidecar: PropTypes.object.isRequired, | |||
| collectors: PropTypes.array.isRequired, | |||
There was a problem hiding this comment.
Going to a sidecar details page, I'm seeing the following in my JS console:
Warning: Failed prop type: The prop `collectors` is marked as required in `SidecarStatus`, but its value is `undefined`.
in SidecarStatus (created by SidecarStatusPage)
in SidecarStatusPage (created by ReactProxy)
| @@ -25,6 +26,7 @@ class SidecarStatusPage extends React.Component { | |||
|
|
|||
| componentDidMount() { | |||
| this.reloadSidecar(); | |||
| this.reloadCollectors(); | |||
There was a problem hiding this comment.
Do we also need to automatically reload collectors, or is it fine to only load them on page load? I guess the second option is fine, but want to double-check :)
There was a problem hiding this comment.
Loading them once is good enough.
|
I think the |
There was a problem hiding this comment.
@mariussturm I am seeing the following issue:
The collector status is always unknown
In the sidecar overview the status of a collector is "running":
Related to Graylog2/collector-sidecar#262
Fixes Graylog2/collector-sidecar#255
Description
After merging Graylog2/collector-sidecar#262 the Sidecar will only report the Collector-ID in the corresponding status response. So we have to change the response model as well as the frontend to resolve the ID to an actual collector name on the status page.