Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming a collector backend results in duplicate processes #255

Closed
bernd opened this issue Jul 6, 2018 · 0 comments · Fixed by Graylog2/graylog2-server#4903
Closed

Renaming a collector backend results in duplicate processes #255

bernd opened this issue Jul 6, 2018 · 0 comments · Fixed by Graylog2/graylog2-server#4903
Labels
blocker If not finished by release date, the release will be postponed. bug triaged
Milestone
3.0.0

Comments

@bernd
Copy link
Member

bernd commented Jul 6, 2018 •
edited
Loading

Problem description

When renaming a collector backend in the UI, the sidecar picks up the new configuration and starts another process of the same type.

In my case I renamed a filebeat backend and saw two running filebeat processes. The sidecar should have stopped the old one and started a new one with the new name.

We might want to consider using the backend ID instead of the backend name as an internal identifier in the sidecar.

Restarting the sidecar process helped. Only the backend with the new name got started after a restart.

Steps to reproduce the problem

  1. Create a collector backend in the UI
  2. Create a collector configuration and use the newly created backend
  3. Assign the new collector configuration to a collector on a sidecar node
  4. Wait until the sidecar has started the collector process
  5. Rename the collector backend in the UI
  6. Wait until the sidecar received the update configurations
  7. ➡️ See the same process started twice

Environment

  • Sidecar Version: 1.0.0-alpha.2 (rev 67efefc)
  • Graylog Version: 3.0.0-alpha.2-SNAPSHOT (rev 7b3717728)
@bernd bernd added bug blocker If not finished by release date, the release will be postponed. labels Jul 6, 2018
@bernd bernd added this to the 3.0.0 milestone Jul 6, 2018
@joschi joschi added the triaged label Jul 9, 2018
This was referenced Jul 11, 2018
Merged
Merged
bernd pushed a commit to Graylog2/graylog2-server that referenced this issue Jul 19, 2018
@bernd
Sidecar collector rename (#4903)
36438c2 
* Remove defaultTemplate from collector summary

* Use collector_id for status reference

* Fix typo

* Move collector loading to StatusPage

* Use arrow function and prevent load time warning if collectors list is not ready yet

* Fix collector status on Sidecar administration page

Fixes Graylog2/collector-sidecar#255
bernd pushed a commit that referenced this issue Jul 19, 2018
@bernd
Use collector ID as reference to avoid naming conflicts (#262)
fde7741 
Fixes #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker If not finished by release date, the release will be postponed. bug triaged
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Sidecar collector rename Graylog2/graylog2-server
2 participants
@bernd @joschi