Filter system event definitions from content pack generation #21206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingzacko1
approved these changes
Dec 17, 2024
garybot2
pushed a commit
that referenced
this pull request
Dec 19, 2024
* filters system event definitions from content pack generation * adding changelog (cherry picked from commit 8aafad6)
9 tasks
garybot2
pushed a commit
that referenced
this pull request
Dec 19, 2024
* filters system event definitions from content pack generation * adding changelog (cherry picked from commit 8aafad6)
9 tasks
garybot2
pushed a commit
that referenced
this pull request
Dec 19, 2024
* filters system event definitions from content pack generation * adding changelog (cherry picked from commit 8aafad6)
9 tasks
danotorrey
pushed a commit
that referenced
this pull request
Jan 29, 2025
…#21220) * filters system event definitions from content pack generation * adding changelog (cherry picked from commit 8aafad6) Co-authored-by: Jan Heise <[email protected]>
danotorrey
pushed a commit
that referenced
this pull request
Jan 29, 2025
…#21221) * filters system event definitions from content pack generation * adding changelog (cherry picked from commit 8aafad6) Co-authored-by: Jan Heise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, a system event definition shows up in the list of exportable definitions for content packs. This leads to an error later on in content pack export. This PR filters the entities like with other definitions (anomaly etc.)
fixes #21166
solves customer issue
needs backport
Motivation and Context
How Has This Been Tested?
Tested manually by trying to create a content pack and look at the list of event definitions.
Screenshots (if appropriate):
Types of changes
Checklist: