Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match collector_binaries_accesslist case insensitive on windows and MacOS #467

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

mpfz0r
Copy link
Contributor

@mpfz0r mpfz0r commented Feb 9, 2023

Both usually have case-insensitive file systems.

Feels like this should be fixed in go instead:
golang/go#5441

Also remove a stray go.mod file, that causes IJ to throw a warning on startup.

Fixes #364

@mpfz0r mpfz0r changed the title Match collector_binaries_accesslist case insensitive on windows Match collector_binaries_accesslist case insensitive on windows and MacOS Feb 9, 2023
@mpfz0r mpfz0r marked this pull request as ready for review February 9, 2023 12:41
@mpfz0r mpfz0r requested a review from thll February 9, 2023 12:43
@thll thll self-assigned this Feb 10, 2023
Copy link
Contributor

@thll thll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested successfully on Darwin.

@thll thll merged commit a0bc10d into master Feb 10, 2023
@thll thll deleted the issue-364 branch February 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match collectors binary whitelist case insensitive on Windows
2 participants