Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match collectors binary whitelist case insensitive on Windows #364

Closed
mpfz0r opened this issue May 3, 2019 · 1 comment · Fixed by #467
Closed

Match collectors binary whitelist case insensitive on Windows #364

mpfz0r opened this issue May 3, 2019 · 1 comment · Fixed by #467
Assignees
@mpfz0r
Labels
enhancement feature improvement triaged ux windows

Comments

@mpfz0r
Copy link
Contributor

mpfz0r commented May 3, 2019

Problem description

Windows filesystems are case insensitive.
We should make the collectors_binary_whitelist matching ignore case.

refs #363
@deeshe deeshe added the triaged label May 13, 2019
@coffee-squirrel
Copy link

We got bit by this when installing the Sidecar on a shared system that was still running the Collector Sidecar. The latter was installed to C:\Program Files\graylog\collector-sidecar, while the newer Sidecar would have installed to C:\Program Files\Graylog\sidecar. Since the graylog directory already existed it was reused when the Sidecar got installed.

The Sidecar collector definitions reference C:\Program Files\Graylog\sidecar\whatever.exe, so we were getting a collectors_binary_whitelist error.

We ended up just stopping the Windows services and renaming the directory from graylog to Graylog.

@mpfz0r mpfz0r self-assigned this Jun 23, 2020
@boosty boosty added the windows label Aug 22, 2022
mpfz0r added a commit that referenced this issue Feb 9, 2023
@mpfz0r
Match collector_binaries_accesslist case insensitive on windows
e5161ef 
Fixes #364
@mpfz0r mpfz0r mentioned this issue Feb 9, 2023
Merged
@thll thll closed this as completed in #467 Feb 10, 2023
thll pushed a commit that referenced this issue Feb 10, 2023
@mpfz0r
Match collector_binaries_accesslist case insensitive on windows and M…
a0bc10d 
…acOS (#467)

* remove unneeded go.mod which triggers a warning in IJ

* Match collector_binaries_accesslist case insensitive on windows

Fixes #364

* also for macos

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpfz0r mpfz0r

Labels
enhancement feature improvement triaged ux windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match collector_binaries_accesslist case insensitive on windows and MacOS Graylog2/collector-sidecar
4 participants
@boosty @mpfz0r @coffee-squirrel @deeshe