Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filebeat from linux packages #326

Merged
merged 4 commits into from
Jan 15, 2019
Merged

Remove filebeat from linux packages #326

merged 4 commits into from
Jan 15, 2019

Conversation

mpfz0r
Copy link
Contributor

@mpfz0r mpfz0r commented Jan 9, 2019

Linux users should install their collectors from elastic

Linux users should install their collectors from elastic
Copy link
Contributor

@mariussturm mariussturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the nxlog spool directory to be collector independent? Would need to be reflected in the default config as well.

@bernd
Copy link
Member

bernd commented Jan 9, 2019

I think it would be great if every collector instance gets it's own working directory that is created by the sidecar before starting the collector. We could also expose this as a sidecar. variable. Otherwise the user has to make sure that certain directories exist before a collector can start.

@mariussturm
Copy link
Contributor

Ok, then we should add working directories for all default collectors or even for all that are listed in collector_binaries_whitelist.

@bernd
Copy link
Member

bernd commented Jan 9, 2019

Ok, then we should add working directories for all default collectors or even for all that are listed in collector_binaries_whitelist.

If we do that, I think we need a working directory for every instance. If I want to run two separate instances of filebeat on one sidecar node we cannot really use the same working directory.

But I think the working directory stuff is a new feature and out of scope for 3.0, unfortunately.

@mariussturm
Copy link
Contributor

Sure we can create them dynamically in a future version but what about that one static directory we have now in the package?

@bernd
Copy link
Member

bernd commented Jan 9, 2019

Sure we can create them dynamically in a future version but what about that one static directory we have now in the package?

Does the nxlog package create a spool directory already? I am not sure why we created the nxlog spool directory in the sidecar package in the first place. Can you elaborate?

@mariussturm
Copy link
Contributor

The official package creates /var/spool/nxlog. The intention was that we don't wanted to create a collision with Sidecar managed and other running instances. So the main question is if we want to keep that separation or if we want to rely on directories that are provided by the standard collector packages as they are the recommend way of installing collectors anyway now? Same would be true for Filebeat then.

@bernd
Copy link
Member

bernd commented Jan 9, 2019

So the main question is if we want to keep that separation or if we want to rely on directories that are provided by the standard collector packages as they are the recommend way of installing collectors anyway now?

My personal opinion is that the sidecar should manage everything that is needed for a collector instance to run (spool, log, cache, ...) in a separate location. (e.g. /var/lib/graylog-sidecar/work/...) Otherwise the user needs to make sure that the filebeat, nxlog and winlogbeat services that get installed by the official packages are disabled and not in use. The user also needs to manually create log and spool directories if she wants to manage multiple instances of filebeat or nxlog on the same sidecar node.

I think having the separation makes it easier for the user to use the sidecar system in general.

What do you think @mariussturm @mpfz0r? 😃

@mariussturm
Copy link
Contributor

I agree, the Sidecar should manage the directories for each collector instance (PID is another example) but till we don't have dynamic creation I would go with a static spool directory for every default collector. It's fairly simple to put a second directory next to it if a user needs it. The collector configuration needs to be adopted anyway in that case.
The default Filebeat config is using this:

path:
  data: /var/cache/graylog-sidecar/filebeat/data"
  logs: /var/log/graylog-sidecar"

So we could create at least the spool dir. Windows needs to be checked as well.

@mpfz0r
Copy link
Contributor Author

mpfz0r commented Jan 11, 2019

Moving this discussion to: #331

The wrapper scripts have hardcoded paths, that we cannot overwrite
with the configuration.
@mariussturm mariussturm merged commit 591e771 into master Jan 15, 2019
@mariussturm mariussturm deleted the remove-beats branch January 15, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants