-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove filebeat from linux packages #326
Conversation
Linux users should install their collectors from elastic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove the nxlog spool directory to be collector independent? Would need to be reflected in the default config as well.
I think it would be great if every collector instance gets it's own working directory that is created by the sidecar before starting the collector. We could also expose this as a |
Ok, then we should add working directories for all default collectors or even for all that are listed in |
If we do that, I think we need a working directory for every instance. If I want to run two separate instances of filebeat on one sidecar node we cannot really use the same working directory. But I think the working directory stuff is a new feature and out of scope for 3.0, unfortunately. |
Sure we can create them dynamically in a future version but what about that one static directory we have now in the package? |
Does the nxlog package create a spool directory already? I am not sure why we created the nxlog spool directory in the sidecar package in the first place. Can you elaborate? |
The official package creates |
My personal opinion is that the sidecar should manage everything that is needed for a collector instance to run (spool, log, cache, ...) in a separate location. (e.g. I think having the separation makes it easier for the user to use the sidecar system in general. What do you think @mariussturm @mpfz0r? 😃 |
I agree, the Sidecar should manage the directories for each collector instance (PID is another example) but till we don't have dynamic creation I would go with a static spool directory for every default collector. It's fairly simple to put a second directory next to it if a user needs it. The collector configuration needs to be adopted anyway in that case.
So we could create at least the spool dir. Windows needs to be checked as well. |
Moving this discussion to: #331 |
The wrapper scripts have hardcoded paths, that we cannot overwrite with the configuration.
Linux users should install their collectors from elastic