Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unique working directory for each collector backend #331

Closed
mpfz0r opened this issue Jan 11, 2019 · 2 comments
Closed

Generate unique working directory for each collector backend #331

mpfz0r opened this issue Jan 11, 2019 · 2 comments
Labels
blocker If not finished by release date, the release will be postponed. feature needs-discussion triaged

Comments

@mpfz0r
Copy link
Contributor

mpfz0r commented Jan 11, 2019

Each collector relies on a place to write its own logs, spool files, etc.
We want to ensure that multiple collectors don't step on each others toes.

Possible solution:

  • Redefine collector_configuration_directory: to collector_data_root_directory:
    with a default of /var/lib/graylog-sidecar/collector-data/

  • For each configuration assignment, auto-generate the following subdirectories:
    $collector_data_root_directory/<backend-name>/<config-name>/ or maybe
    $collector_data_root_directory/<backend-id>/<config-id>/

  • Report the value of collector_data_root_directory back to Graylog, so we can
    generate a variable ${sidecar.dataRoot} and maybe ${sidecar.collectorDataDir}.
    This can be used in collector configurations like:

path.data: ${sidecar.collectorDataDir}/data
path.log: ${sidecar.collectorDataDir}/log

Open questions:

  • Which permissions should we give this directory?
  • Do we need clean up on de configuration of a collector
  • Do we need a UI
@mpfz0r mpfz0r added blocker If not finished by release date, the release will be postponed. feature labels Jan 11, 2019
@mpfz0r mpfz0r added this to the 3.0.0 milestone Jan 11, 2019
@mariussturm mariussturm modified the milestones: 3.0.0, 3.1.0 Jan 14, 2019
@dennisoelkers dennisoelkers changed the title Generate uniqe working directory for each collector backend Generate unique working directory for each collector backend Mar 4, 2019
@bernd bernd removed this from the 3.1.0-legacy milestone Jan 27, 2022
@bernd
Copy link
Member

bernd commented Nov 7, 2022

We do this now. Yay!

@bernd bernd closed this as completed Nov 7, 2022
@mpfz0r
Copy link
Contributor Author

mpfz0r commented Nov 7, 2022

Hah. Totally forgot about my own ticket :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker If not finished by release date, the release will be postponed. feature needs-discussion triaged
Projects
None yet
Development

No branches or pull requests

4 participants