Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of applying Shadow plugin for itself #967

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Sep 11, 2024

Closes #965.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler force-pushed the g/get-rid-of-shadow-self branch from 27babec to 9b05d8e Compare September 11, 2024 15:19
@Goooler
Copy link
Member Author

Goooler commented Sep 11, 2024

dua .m2/repository/com/gradleup/shadow/shadow-gradle-plugin/8.3.1-SNAPSHOT/
   4.10 KB maven-metadata-local.xml
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT-all.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT-javadoc.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT-sources.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.module.asc
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.pom
   4.10 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.pom.asc
   8.19 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.module
  65.54 KB shadow-gradle-plugin-8.3.1-SNAPSHOT-sources.jar
  90.11 KB shadow-gradle-plugin-8.3.1-SNAPSHOT-javadoc.jar
 368.64 KB shadow-gradle-plugin-8.3.1-SNAPSHOT.jar
   8.49 MB shadow-gradle-plugin-8.3.1-SNAPSHOT-all.jar
   9.06 MB total

dua .m2/repository/com/gradleup/shadow/shadow-gradle-plugin/8.3.2-SNAPSHOT/
   4.10 KB maven-metadata-local.xml
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT-javadoc.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT-sources.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.jar.asc
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.module.asc
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.pom
   4.10 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.pom.asc
   8.19 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.module
  65.54 KB shadow-gradle-plugin-8.3.2-SNAPSHOT-sources.jar
  90.11 KB shadow-gradle-plugin-8.3.2-SNAPSHOT-javadoc.jar
 368.64 KB shadow-gradle-plugin-8.3.2-SNAPSHOT.jar
 561.15 KB total
diff shadow-gradle-plugin-8.3.1-SNAPSHOT.pom shadow-gradle-plugin-8.3.2-SNAPSHOT.pom

12c12
<   <version>8.3.1-SNAPSHOT</version>
---
>   <version>8.3.2-SNAPSHOT</version>
97,103d96
<     <dependency>
<       <groupId>org.codehaus.groovy</groupId>
<       <artifactId>groovy-backports-compat23</artifactId>
<       <version>3.0.8</version>
<       <scope>compile</scope>
<       <optional>true</optional>
<     </dependency>
diffuse diff --jar shadow-gradle-plugin-8.3.1-SNAPSHOT.jar shadow-gradle-plugin-8.3.2-SNAPSHOT.jar

OLD: shadow-gradle-plugin-8.3.1-SNAPSHOT.jar
NEW: shadow-gradle-plugin-8.3.2-SNAPSHOT.jar

 JAR   │ old       │ new       │ diff
───────┼───────────┼───────────┼──────────
 class │ 737.7 KiB │ 740.3 KiB │ +2.5 KiB
 other │  10.6 KiB │  10.7 KiB │    +89 B
───────┼───────────┼───────────┼──────────
 total │ 748.3 KiB │ 750.9 KiB │ +2.6 KiB

 CLASSES │ old  │ new  │ diff
─────────┼──────┼──────┼────────────
 classes │  154 │  155 │ +1 (+1 -0)
 methods │ 1909 │ 1917 │ +8 (+8 -0)
  fields │  796 │  801 │ +5 (+5 -0)

=================
====   JAR   ====
=================

 size    │ diff     │ path
─────────┼──────────┼─────────────────────────────────────────────────────────────────────────────────
 2.4 KiB │ +2.4 KiB │ + com/github/jengelman/gradle/plugins/shadow/legacy/LegacyShadowPlugin.class
    89 B │    +89 B │ + META-INF/gradle-plugins/com.github.johnrengelman.shadow.properties
     0 B │      0 B │ + com/github/jengelman/gradle/plugins/shadow/legacy/
 3.7 KiB │   +122 B │ ∆ com/github/jengelman/gradle/plugins/shadow/ShadowPlugin$_apply_closure1.class
─────────┼──────────┼─────────────────────────────────────────────────────────────────────────────────
 6.2 KiB │ +2.6 KiB │ (total)


=====================
====   CLASSES   ====
=====================

CLASSES:

   old │ new │ diff
  ─────┼─────┼────────────
   154 │ 155 │ +1 (+1 -0)

  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin


METHODS:

   old  │ new  │ diff
  ──────┼──────┼────────────
   1909 │ 1917 │ +8 (+8 -0)

  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $createCallSiteArray() → CallSiteArray
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $getCallSiteArray() → CallSite[]
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $getStaticMetaClass() → MetaClass
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin <init>()
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin apply(Object)
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin apply(Project)
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin getMetaClass() → MetaClass
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin setMetaClass(MetaClass)


FIELDS:

   old │ new │ diff
  ─────┼─────┼────────────
   796 │ 801 │ +5 (+5 -0)

  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $callSiteArray: SoftReference
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $staticClassInfo: ClassInfo
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin $staticClassInfo$: ClassInfo
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin __$stMC: boolean
  + com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin metaClass: MetaClass

@Goooler Goooler merged commit 0967c74 into main Sep 11, 2024
9 checks passed
@Goooler Goooler deleted the g/get-rid-of-shadow-self branch September 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin jar contains registration for missing Log4J annotation processor
1 participant