Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin jar contains registration for missing Log4J annotation processor #965

Closed
marcphilipp opened this issue Sep 11, 2024 · 4 comments · Fixed by #967
Closed

Plugin jar contains registration for missing Log4J annotation processor #965

marcphilipp opened this issue Sep 11, 2024 · 4 comments · Fixed by #967
Labels

Comments

@marcphilipp
Copy link
Contributor

Expected and Results

The shadow-gradle-plugin-8.3.1.jar contains a META-INF/services/javax.annotation.processing.Processor file that contains a reference to org.apache.logging.log4j.core.config.plugins.processor.PluginProcessor but the annotation processor is not part of the JAR.

I strongly suspect the plugin jar should not contain a META-INF/services/javax.annotation.processing.Processor file at all.

Related environent and versions

8.3.1

Reproduction steps

This yields to problems when compiling Java classes with the plugin jar on the classpath and not using the -proc:none compiler arg.

Anything else?

No response

@Goooler
Copy link
Member

Goooler commented Sep 11, 2024

Thanks for the heads-up! This is due to #960 (comment).

@Goooler
Copy link
Member

Goooler commented Sep 11, 2024

@marcphilipp Could you try out 8.3.2-SNAPSHOT?

@marcphilipp
Copy link
Contributor Author

The latest snapshot resolves the issue. Thanks for the quick turnaround! 👍

@Goooler
Copy link
Member

Goooler commented Sep 12, 2024

Thanks for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants