Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ShadowJar to using lazy properties #1044

Merged
merged 20 commits into from
Nov 26, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Nov 26, 2024

Refs #1036.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler force-pushed the g/migrate-shadow-jar-to-lazy-properties branch from a314424 to fe90f43 Compare November 26, 2024 06:15
@Goooler Goooler requested a review from Copilot November 26, 2024 06:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • api/shadow.api: Language not supported
  • lint-baseline.xml: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/UnusedTracker.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
…to-lazy-properties

// Conflicts:
//	src/docs/changes/README.md
//	src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
@Goooler Goooler requested a review from Copilot November 26, 2024 09:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • api/shadow.api: Language not supported
  • lint-baseline.xml: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/UnusedTracker.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
@Goooler Goooler merged commit 941e065 into main Nov 26, 2024
7 checks passed
@Goooler Goooler deleted the g/migrate-shadow-jar-to-lazy-properties branch November 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant