Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate transformers to using lazy properties #1036

Merged
merged 29 commits into from
Nov 27, 2024
Merged

Migrate transformers to using lazy properties #1036

merged 29 commits into from
Nov 27, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Nov 21, 2024


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler force-pushed the g/lazy-properties branch 4 times, most recently from de2ef05 to 7e5148a Compare November 25, 2024 03:46
@Goooler Goooler requested a review from Copilot November 25, 2024 08:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (12)
  • api/shadow.api: Language not supported
  • lint-baseline.xml: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/UnusedTracker.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformer.kt: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
@Goooler Goooler force-pushed the g/lazy-properties branch 7 times, most recently from 518ecce to fa22933 Compare November 26, 2024 03:18
@Goooler Goooler changed the base branch from main to g/migrate-shadow-jar-to-lazy-properties November 26, 2024 06:17
@Goooler Goooler changed the title Migrate to lazy properties Migrate transformers to using lazy properties Nov 26, 2024
Base automatically changed from g/migrate-shadow-jar-to-lazy-properties to main November 26, 2024 09:37
@Goooler Goooler force-pushed the g/lazy-properties branch 2 times, most recently from 8d1347b to 1df7b3b Compare November 26, 2024 10:25
@Goooler Goooler marked this pull request as ready for review November 26, 2024 15:38
@Goooler Goooler requested a review from Copilot November 26, 2024 15:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 22 changed files in this pull request and generated no suggestions.

Files not reviewed (20)
  • api/shadow.api: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/DontIncludeResourceTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/IncludeResourceTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestResourceTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Transformer.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/XmlAppendingTransformer.kt: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformerParameterTests.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformerTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformerTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformerTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerSpec.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/TransformerSpecSupport.groovy: Language not supported
@Goooler Goooler merged commit 7bd3c3f into main Nov 27, 2024
7 checks passed
@Goooler Goooler deleted the g/lazy-properties branch November 27, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant