-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Add a save button to the google analytics id form #4336
Conversation
Size Change: +196 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #4336 +/- ##
===========================================
+ Coverage 70.35% 83.28% +12.93%
===========================================
Files 836 836
Lines 14797 14812 +15
===========================================
+ Hits 10410 12336 +1926
+ Misses 4387 2476 -1911
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great and solves the issue of not knowing how to save the tracking ID. Few small things.
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and the screen reader + focus works too!
Verified in QA |
Summary
Add a save button to the google analytics id form
User-facing changes
Testing Instructions
#3843