Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Add a save button to the google analytics id form #4336

Merged
merged 12 commits into from
Sep 8, 2020

Conversation

dmmulroy
Copy link
Contributor

@dmmulroy dmmulroy commented Sep 3, 2020

Summary

Add a save button to the google analytics id form

no-change

change

User-facing changes

  • Adds a button to the google analytics id form that becomes disabled under two exclusive conditions:
  1. You supply an invalid GA id
  2. You type in the currently saved GA id

Testing Instructions

  • Navigate to Editor Settings
  • Type in a valid GA id (ua-#-#) and click save. Refresh the page and see that the GA id you entered is the value in the text box
  • Edit the GA id to another valid GA id and press Enter. Refresh the page and see that the GA id you entered is the value in the text box
  • Delete the value from Input box and press Enter/Click Save. Refresh the page to see that there is no GA id.

#3843

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2020

Size Change: +196 B (0%)

Total Size: 1.24 MB

Filename Size Change
assets/js/stories-dashboard.js 584 kB +196 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 296 B 0 B
assets/css/stories-dashboard.css 328 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.86 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 9.91 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.78 kB 0 B
assets/js/edit-story.js 495 kB 0 B
assets/js/web-stories-activation-notice.js 63.6 kB 0 B
assets/js/web-stories-embed-block.js 16.9 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #4336 into main will increase coverage by 12.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4336       +/-   ##
===========================================
+ Coverage   70.35%   83.28%   +12.93%     
===========================================
  Files         836      836               
  Lines       14797    14812       +15     
===========================================
+ Hits        10410    12336     +1926     
+ Misses       4387     2476     -1911     
Flag Coverage Δ
#karmatests 71.29% <100.00%> (+41.75%) ⬆️
#unittests 66.33% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/app/views/myStories/header/index.js 93.33% <ø> (ø)
...c/dashboard/app/views/editorSettings/components.js 100.00% <100.00%> (ø)
.../app/views/editorSettings/googleAnalytics/index.js 100.00% <100.00%> (ø)
assets/src/dashboard/constants/index.js 100.00% <100.00%> (ø)
.../src/dashboard/components/inlineInputForm/index.js 90.90% <0.00%> (-9.10%) ⬇️
...s/src/edit-story/components/panels/sizePosition.js 91.48% <0.00%> (+2.12%) ⬆️
assets/src/edit-story/elements/text/frame.js 97.50% <0.00%> (+2.50%) ⬆️
...edit-story/components/panels/panel/shared/title.js 81.08% <0.00%> (+2.70%) ⬆️
assets/src/edit-story/components/button/index.js 97.29% <0.00%> (+2.70%) ⬆️
...ponents/library/panes/media/media3p/media3pPane.js 93.75% <0.00%> (+3.12%) ⬆️
... and 180 more

Copy link
Contributor

@BrittanyIRL BrittanyIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great and solves the issue of not knowing how to save the tracking ID. Few small things.

@dmmulroy dmmulroy requested a review from BrittanyIRL September 3, 2020 22:27
Copy link
Contributor

@BrittanyIRL BrittanyIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and the screen reader + focus works too!

@csossi
Copy link

csossi commented Sep 7, 2020

Verified in QA

@dmmulroy dmmulroy merged commit c54a36b into main Sep 8, 2020
@dmmulroy dmmulroy deleted the bug/3843-save-analytics-id branch September 8, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard Group: Settings Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Settings: Unclear how to save analytics ID updates
5 participants