Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Settings: Unclear how to save analytics ID updates #3843

Closed
BrittanyIRL opened this issue Aug 12, 2020 · 2 comments · Fixed by #4336
Closed

Dashboard Settings: Unclear how to save analytics ID updates #3843

BrittanyIRL opened this issue Aug 12, 2020 · 2 comments · Fixed by #4336
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Dashboard Type: Bug Something isn't working

Comments

@BrittanyIRL
Copy link
Contributor

This is somewhere between a bug and a feature - I think it's just an implementation detail that didn't get communicated/lost in the shuffle.

Bug Description

It is not clear how to save new analytics IDs in the UI
Screen Shot 2020-08-12 at 11.52.06 AM.png

Expected Behaviour

It should be clear to all users how to submit an update in this input. The same issue will exist for updating story names in the dashboard since this is a shared form component. Do we want a button of some sort or are we to save automatically when the input has lost focus?

Steps to Reproduce

Dashboard > Settings > update the Google Analytics Tracking ID, now you have to hit enter.

Additional Context

  • Plugin Version:
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@BrittanyIRL BrittanyIRL added Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Estimate Needed Group: Dashboard Type: Bug Something isn't working UX Needed labels Aug 12, 2020
This was referenced Aug 12, 2020
Merged
Closed
@BrittanyIRL BrittanyIRL added this to the Sprint 36 milestone Aug 26, 2020
@samitron7
Copy link

Add a save button here

@dmmulroy dmmulroy self-assigned this Sep 2, 2020
@dmmulroy dmmulroy mentioned this issue Sep 3, 2020
Merged
@dmmulroy dmmulroy linked a pull request Sep 3, 2020 that will close this issue
Dashboard: Add a save button to the google analytics id form #4336
Merged
@swissspidy
Copy link
Collaborator

Needs UAT

@swissspidy swissspidy reopened this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Dashboard Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dashboard: Add a save button to the google analytics id form GoogleForCreators/web-stories-wp
5 participants
@swissspidy @dmmulroy @BrittanyIRL @samitron7 @o-fernandez