-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Add checks for logos dimensions #4313
Conversation
Size Change: +254 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #4313 +/- ##
===========================================
+ Coverage 70.02% 83.12% +13.10%
===========================================
Files 835 835
Lines 14728 14748 +20
===========================================
+ Hits 10313 12260 +1947
+ Misses 4415 2488 -1927
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tricky to test but I think we can create a Mock Image object with a blob of random data and some metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Pascal's error message changes, but functionally and code-ically it works! Nice job!!
Co-authored-by: Pascal Birchler <[email protected]>
Co-authored-by: Pascal Birchler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Adds error messages in the case that uploaded logos are smaller than 96x96.
User-facing changes
Sorry, this file's dimensions are too small. Make sure your logo is larger than 96x96.
Sorry, one or more of these files dimension's are too small. Make sure your logos are all larger than 96x96.
Testing Instructions
#4147