Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Settings: Publisher Logo Dimension Check #4147

Closed
BrittanyIRL opened this issue Aug 20, 2020 · 4 comments
Closed

Dashboard Settings: Publisher Logo Dimension Check #4147

BrittanyIRL opened this issue Aug 20, 2020 · 4 comments
Labels
Group: Dashboard P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@BrittanyIRL
Copy link
Contributor

Feature Description

When a new publisher logo is added we should check that it is the proper dimensions. If it is not at least 96px x 96px a warning should show.

Alternatives Considered

Additional Context

#2747
https://docs.google.com/document/d/1Xs4uOZ3KCNlTMdjDT6q7cvTUpA1xk-kzrnVLQALltQk/edit#heading=h.g8j12riqi2ft


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Only images that are 96px x 96px or larger should be accepted as publisher logos on the settings view

Implementation Brief

  • We can either check this locally or in the settings API when a new logo is added.
@BrittanyIRL
Copy link
Contributor Author

@o-fernandez - just confirming that this is something we want for 1.0 - stable since it's something we want to do on the backend and will require workspace time. This dimension check is not currently something that's in place in the editor either when you set publisher logos there.

@o-fernandez
Copy link
Contributor

@o-fernandez - just confirming that this is something we want for 1.0 - stable since it's something we want to do on the backend and will require workspace time. This dimension check is not currently something that's in place in the editor either when you set publisher logos there.

We could delay the check, but should at least tell users that we recommend 96x96px publisher logos.

@BrittanyIRL
Copy link
Contributor Author

Screen Shot 2020-08-26 at 1 04 26 PM

Does this suffice for now?

@barklund barklund added the P2 Should do soon label Aug 26, 2020
@dmmulroy dmmulroy self-assigned this Sep 2, 2020
@csossi
Copy link

csossi commented Sep 4, 2020

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants