Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Bug fixes for color panel translation and detail template capitalization #2311

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

BrittanyIRL
Copy link
Contributor

Summary

Two small bug fixes to improve internationalization.

  1. Giving the color dropdown that shows [color 1] + n a true plural option for if translations need it.
  2. Moving the forced capitalization of a button on the detail template view to css.

Relevant Technical Choices

  • using _n not __ for plural of numbers in i18n

To-do

N/A

User-facing changes

  • None, should appear the exact same to the user
    (Areas to regression test are the color filter on templates and the 'USE TEMPLATE' button on the detail template view)

Testing Instructions

  • Regression test that the color label updates the same on the template color picker
  • and that the 'USE TEMPLATE' button on the detail view of template is still all caps.

Addresses #2293

@BrittanyIRL BrittanyIRL added this to the Sprint 29 milestone Jun 8, 2020
@BrittanyIRL BrittanyIRL self-assigned this Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #2311 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2311   +/-   ##
=========================================
  Coverage     66.12%   66.13%           
  Complexity      314      314           
=========================================
  Files           651      651           
  Lines         10735    10736    +1     
=========================================
+ Hits           7099     7100    +1     
  Misses         3636     3636           
Impacted Files Coverage Δ Complexity Δ
assets/src/dashboard/components/dropdown/index.js 86.53% <ø> (ø) 0.00 <0.00> (ø)
...s/src/dashboard/components/templateNavBar/index.js 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

Size Change: +33 B (0%)

Total Size: 829 kB

Filename Size Change
assets/js/stories-dashboard.js 441 kB +33 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 269 B 0 B
assets/css/stories-dashboard.css 305 B 0 B
assets/css/web-stories-embed-block.css 501 B 0 B
assets/js/edit-story.js 371 kB 0 B
assets/js/web-stories-embed-block.js 15.7 kB 0 B

compressed-size-action

Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🎉 👍

@BrittanyIRL BrittanyIRL force-pushed the task/2293-i18n-numbers branch from 7f2d326 to db30d7e Compare June 8, 2020 20:52
@BrittanyIRL BrittanyIRL merged commit 09dd19f into master Jun 8, 2020
@BrittanyIRL BrittanyIRL deleted the task/2293-i18n-numbers branch June 8, 2020 22:24
@BrittanyIRL BrittanyIRL linked an issue Jun 11, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: Do not use capitalized strings for internationalization
4 participants