Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Do not use capitalized strings for internationalization #2291

Closed
swissspidy opened this issue Jun 8, 2020 · 1 comment · Fixed by #2311
Closed

Dashboard: Do not use capitalized strings for internationalization #2291

swissspidy opened this issue Jun 8, 2020 · 1 comment · Fixed by #2311

Comments

@swissspidy
Copy link
Collaborator

Bug Description

In the TemplateNavBar the string Use template is written in all caps:

https://github.com/google/web-stories-wp/blob/c3323311aa68c70944f53d8a651035c61ab9a829/assets/src/dashboard/components/templateNavBar/index.js#L87-L89

This is not ideal for translators, especially since the string Use template already exists a few times. So this would duplicate strings.

Expected Behaviour

Use template should be written like so, and capitalized with CSS (text-transform: uppercase).

Steps to Reproduce

Check out a template on the dashboard.

Screenshots

Screenshot 2020-06-08 at 12 10 41

Additional Context

  • Plugin Version: master
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

@BrittanyIRL
Copy link
Contributor

Fixed w/ other small text bug: #2293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants