Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267

Merged
merged 7 commits into from
Jan 31, 2024
+63 −9
Merged

feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f0273c4
feat: extracted kaniko copyTimeout and copyMaxRetries into config
idsulik Jan 19, 2024
82fb38a
updated defaults_test.go
idsulik Jan 19, 2024
475d5df
added v4beta9 schema
idsulik Jan 20, 2024
3091b64
Merge branch 'main' into feature/added-kaniko-copy-config
idsulik Jan 31, 2024
9cfe6a9
fixed code style pkg/skaffold/build/cluster/kaniko.go
idsulik Jan 31, 2024
2a150f8
updated schema
idsulik Jan 31, 2024
fa9df48
fixed versions_test.go
idsulik Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
updated defaults_test.go
@idsulik
idsulik committed Jan 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 82fb38ae4dcb44ad2e581455a6a9dd45d9bd3779
10 changes: 10 additions & 0 deletions pkg/skaffold/schema/defaults/defaults_test.go
View file
Original file line number Diff line number Diff line change
@@ -83,6 +83,12 @@ func TestSetDefaults(t *testing.T) {
},
Sync: &latest.Sync{Auto: util.Ptr(false)},
},
{
ImageName: "eights",
ArtifactType: latest.ArtifactType{
KanikoArtifact: &latest.KanikoArtifact{},
},
},
},
},
},
@@ -126,6 +132,10 @@ func TestSetDefaults(t *testing.T) {
testutil.CheckDeepEqual(t, []string(nil), cfg.Build.Artifacts[6].BuildpackArtifact.Dependencies.Ignore)
testutil.CheckDeepEqual(t, "project.toml", cfg.Build.Artifacts[6].BuildpackArtifact.ProjectDescriptor)
testutil.CheckDeepEqual(t, util.Ptr(false), cfg.Build.Artifacts[6].Sync.Auto)

testutil.CheckDeepEqual(t, "eights", cfg.Build.Artifacts[7].ImageName)
testutil.CheckDeepEqual(t, 3, *cfg.Build.Artifacts[7].KanikoArtifact.CopyMaxRetries)
testutil.CheckDeepEqual(t, "5m", cfg.Build.Artifacts[7].KanikoArtifact.CopyTimeout)
}

func TestSetDefaultsOnCluster(t *testing.T) {