Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated defaults_test.go
idsulik committed Jan 19, 2024
commit 82fb38ae4dcb44ad2e581455a6a9dd45d9bd3779
10 changes: 10 additions & 0 deletions pkg/skaffold/schema/defaults/defaults_test.go
Original file line number Diff line number Diff line change
@@ -83,6 +83,12 @@ func TestSetDefaults(t *testing.T) {
},
Sync: &latest.Sync{Auto: util.Ptr(false)},
},
{
ImageName: "eights",
ArtifactType: latest.ArtifactType{
KanikoArtifact: &latest.KanikoArtifact{},
},
},
},
},
},
@@ -126,6 +132,10 @@ func TestSetDefaults(t *testing.T) {
testutil.CheckDeepEqual(t, []string(nil), cfg.Build.Artifacts[6].BuildpackArtifact.Dependencies.Ignore)
testutil.CheckDeepEqual(t, "project.toml", cfg.Build.Artifacts[6].BuildpackArtifact.ProjectDescriptor)
testutil.CheckDeepEqual(t, util.Ptr(false), cfg.Build.Artifacts[6].Sync.Auto)

testutil.CheckDeepEqual(t, "eights", cfg.Build.Artifacts[7].ImageName)
testutil.CheckDeepEqual(t, 3, *cfg.Build.Artifacts[7].KanikoArtifact.CopyMaxRetries)
testutil.CheckDeepEqual(t, "5m", cfg.Build.Artifacts[7].KanikoArtifact.CopyTimeout)
}

func TestSetDefaultsOnCluster(t *testing.T) {