-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267
feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267
Conversation
Hi! |
@MarlonGamez , hi! Could you please review the PR? The size is big because of generated files(2 new config keys for kaniko), the changes themselves aren't that big. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9267 +/- ##
==========================================
- Coverage 70.48% 63.55% -6.94%
==========================================
Files 515 634 +119
Lines 23150 32721 +9571
==========================================
+ Hits 16317 20795 +4478
- Misses 5776 10322 +4546
- Partials 1057 1604 +547 ☔ View full report in Codecov by Sentry. |
Description
I use skaffold for big project and sometimes it takes more than 5 minutes to create tar(it tries to add more than 80k files) and fails because of timeout, but 5m was hardcoded so I decided to extract it to config.
Changes previews