Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TestModules integration tests #7399

Merged
merged 5 commits into from
May 13, 2022

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented May 12, 2022

fixes #7035, #7330

While working on #7397 , I realized the TestModules_BuildDependency could be failing due to the incorrect skaffold config.

@tejal29 tejal29 requested a review from a team as a code owner May 12, 2022 05:02
@tejal29 tejal29 requested a review from gsquared94 May 12, 2022 05:02
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #7399 (761dbe5) into main (290280e) will decrease coverage by 3.75%.
The diff coverage is 55.77%.

@@            Coverage Diff             @@
##             main    #7399      +/-   ##
==========================================
- Coverage   70.48%   66.72%   -3.76%     
==========================================
  Files         515      568      +53     
  Lines       23150    27189    +4039     
==========================================
+ Hits        16317    18142    +1825     
- Misses       5776     7747    +1971     
- Partials     1057     1300     +243     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 50.00% <0.00%> (-3.85%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <12.50%> (-4.72%) ⬇️
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 55.93% <40.00%> (-20.54%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
... and 297 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 13, 2022
@tejal29 tejal29 enabled auto-merge (squash) May 13, 2022 05:56
@tejal29 tejal29 disabled auto-merge May 13, 2022 05:56
@tejal29 tejal29 merged commit 4516bdb into GoogleContainerTools:main May 13, 2022
@tejal29 tejal29 mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] TestModules_BuildDependency failing on v2 branch
2 participants