Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] TestModules_BuildDependency failing on v2 branch #7035

Closed
tejal29 opened this issue Jan 20, 2022 · 1 comment · Fixed by #7399
Closed

[V2] TestModules_BuildDependency failing on v2 branch #7035

tejal29 opened this issue Jan 20, 2022 · 1 comment · Fixed by #7399
Assignees
@gsquared94
Labels
2.0.0 Issues related to the 2.0.0 release kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Milestone
2.0.0-alpha1

Comments

@tejal29
Copy link
Contributor

tejal29 commented Jan 20, 2022

As per test logs for PR #6949

Log: https://gist.github.com/tejal29/d147b48ead35f859b382110cd590e291#file-gistfile1-txt-L556

Steps to reproduce.

  1. Check out GoogleContainerTools:v2-v1.35.0 : https://github.com/GoogleContainerTools/skaffold/tree/v2-v1.35.0
  2. Run integration test
@tejal29 tejal29 added this to the 2.0.0-alpha milestone Jan 20, 2022
@tejal29 tejal29 added priority/p1 High impact feature/bug. kind/todo implementation task/epic for the skaffold team 2.0.0 Issues related to the 2.0.0 release labels Jan 20, 2022
@tejal29
Copy link
Contributor Author

tejal29 commented Apr 11, 2022 •
edited
Loading

This is still failing.

Please

  1. Skip this test on the main branch via Test.SkipNow() . @marlon-gamez or @gsquared94
  2. @gaurav to fix this part of of [v2] Backport skaffold main features (v1.27+) to v2 branch  #6257

@tejal29 tejal29 assigned MarlonGamez and gsquared94 and unassigned MarlonGamez Apr 11, 2022
@MarlonGamez MarlonGamez removed their assignment May 3, 2022
@tejal29 tejal29 mentioned this issue May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsquared94 gsquared94

Labels
2.0.0 Issues related to the 2.0.0 release kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Projects
None yet
Milestone
2.0.0-alpha1
Development

Successfully merging a pull request may close this issue.

fix: TestModules integration tests tejal29/skaffold
3 participants
@tejal29 @MarlonGamez @gsquared94