Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give logrus.Hook implementation information about task and subtask #6313

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368
Merge after: #6309
Description
This PR adds fields to output.logHook track the task and subtask of the logger it's attached to. This will help fill out the TaskId and SubtaskId fields of the SkaffoldLogEvents that get emitted by the logHook.

Follow-up Work (remove if N/A)
Add hook to new loggers that get created by output.WithEventContext()

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 27, 2021 22:28
@MarlonGamez MarlonGamez requested a review from nkubala July 27, 2021 22:28
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #6313 (f77a6f9) into main (e62f675) will increase coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6313      +/-   ##
==========================================
+ Coverage   70.79%   70.81%   +0.01%     
==========================================
  Files         494      494              
  Lines       22323    22327       +4     
==========================================
+ Hits        15804    15811       +7     
  Misses       5498     5498              
+ Partials     1021     1018       -3     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/logger.go 85.45% <50.00%> (-2.79%) ⬇️
cmd/skaffold/app/cmd/cmd.go 73.65% <100.00%> (ø)
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/docker/image.go 67.56% <0.00%> (+1.01%) ⬆️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62f675...f77a6f9. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 28, 2021
@MarlonGamez MarlonGamez merged commit 27c3822 into GoogleContainerTools:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants