Add logrus.Logger
return type on WithEventContext()
#6309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5368
Description
This change is setup for future PRs. The idea is to return a
logrus.Logger
type that can then be plumbed down into functions that calllogrus
functions. Instead of using the global logger, these functions will use the passed logger which will havelogrus.Hook
s setup to emitSkaffoldLogEvent
messages with properly settaskId
andsubtaskId