Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logrus.Logger return type on WithEventContext() #6309

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368

Description
This change is setup for future PRs. The idea is to return a logrus.Logger type that can then be plumbed down into functions that call logrus functions. Instead of using the global logger, these functions will use the passed logger which will have logrus.Hooks setup to emit SkaffoldLogEvent messages with properly set taskId and subtaskId

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 27, 2021 20:52
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #6309 (d852527) into main (9f0acfa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6309   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files         494      494           
  Lines       22322    22323    +1     
=======================================
+ Hits        15805    15806    +1     
  Misses       5497     5497           
  Partials     1020     1020           
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 64.40% <100.00%> (ø)
pkg/skaffold/build/scheduler.go 92.95% <100.00%> (ø)
pkg/skaffold/deploy/deploy_mux.go 45.45% <100.00%> (ø)
...g/skaffold/kubernetes/portforward/entry_manager.go 91.78% <100.00%> (ø)
pkg/skaffold/kubernetes/status/status_check.go 52.40% <100.00%> (ø)
pkg/skaffold/output/output.go 82.60% <100.00%> (+0.38%) ⬆️
pkg/skaffold/runner/build.go 74.28% <100.00%> (ø)
pkg/skaffold/runner/v1/deploy.go 74.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0acfa...d852527. Read the comment docs.

@MarlonGamez MarlonGamez merged commit e62f675 into GoogleContainerTools:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants