Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add state to event handler to track logrus output events" #6306

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

MarlonGamez
Copy link
Contributor

Reverts #6272

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 27, 2021 19:02
@MarlonGamez MarlonGamez requested a review from nkubala July 27, 2021 19:02
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@MarlonGamez MarlonGamez enabled auto-merge (squash) July 27, 2021 19:04
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #6306 (40e8c3d) into main (1c5e0a8) will increase coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6306      +/-   ##
==========================================
+ Coverage   70.80%   71.01%   +0.21%     
==========================================
  Files         494      494              
  Lines       22325    22458     +133     
==========================================
+ Hits        15807    15949     +142     
+ Misses       5498     5488      -10     
- Partials     1020     1021       +1     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/event.go 84.64% <ø> (-0.22%) ⬇️
pkg/skaffold/event/v2/logger.go 88.23% <0.00%> (+3.32%) ⬆️
pkg/skaffold/docker/image.go 67.56% <0.00%> (+1.01%) ⬆️
pkg/skaffold/schema/validation/validation.go 90.44% <0.00%> (+3.54%) ⬆️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5e0a8...40e8c3d. Read the comment docs.

@MarlonGamez MarlonGamez disabled auto-merge July 27, 2021 22:12
@MarlonGamez MarlonGamez merged commit 8878d8b into main Jul 27, 2021
@MarlonGamez MarlonGamez deleted the revert-6272-logrus-state branch July 27, 2021 22:12
halvards pushed a commit to halvards/skaffold that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants