Add state to event handler to track logrus output events
#6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6272 +/- ##
=======================================
Coverage 70.86% 70.86%
=======================================
Files 490 490
Lines 22162 22168 +6
=======================================
+ Hits 15704 15710 +6
- Misses 5441 5442 +1
+ Partials 1017 1016 -1
Continue to review full report at Codecov.
|
MarlonGamez
changed the title
logrus output taskslogrus output events
nkubala
approved these changes
Jul 27, 2021
gsquared94
reviewed
Jul 27, 2021
| @@ -319,6 +321,7 @@ func TaskInProgress(task constants.Phase, description string) { | |||
| handler.skaffoldLogs = []proto.Event{} | |||
| } | |||
|
|
|||
| handler.task = task | |||
There was a problem hiding this comment.
these assignments will run into race condition
halvards
pushed a commit
to halvards/skaffold
that referenced
this pull request
Jul 28, 2021
…tainerTools#6272) * add state to event handler to track logrus output tasks * linters
halvards
pushed a commit
to halvards/skaffold
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5368
Description
This PR adds a
taskfield to theeventHandlertype to track what the current phase of skaffold is. This is used to populate theSkaffoldLogEvents that come fromlogrusoutput.