Use Helm chart version in render #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5922 +/- ##
==========================================
+ Coverage 70.92% 70.94% +0.01%
==========================================
Files 449 449
Lines 16981 16982 +1
==========================================
+ Hits 12044 12048 +4
+ Misses 4039 4038 -1
+ Partials 898 896 -2
Continue to review full report at Codecov.
|
| { | ||
| description: "deploy remote chart with version", | ||
| commands: testutil. | ||
| CmdRunWithOutput("helm version --client", version31). |
There was a problem hiding this comment.
nit: does helm require semver versions? I don't think so from:
https://helm.sh/docs/helm/helm_dependency/#synopsis
There was a problem hiding this comment.
We require certain versions due to functionality being introduced. In this case, I just copied from the previous test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5887
Merge after: #5921
Description
Use release
versionwhen rendering a remote chart.User facing changes (remove if N/A)
skaffold renderuses remote Helm chart version when specified