Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --user flag to all minikube command invocations #5732

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Apr 27, 2021

Reverts #5682

  1. change the command for minikube version to minikube version --output=json
  2. Add unit tests

@tejal29 tejal29 marked this pull request as ready for review April 27, 2021 18:49
@tejal29 tejal29 requested a review from a team as a code owner April 27, 2021 18:49
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #5732 (8434462) into master (e119e27) will increase coverage by 0.03%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5732      +/-   ##
==========================================
+ Coverage   70.85%   70.88%   +0.03%     
==========================================
  Files         421      421              
  Lines       16050    16076      +26     
==========================================
+ Hits        11372    11396      +24     
  Misses       3845     3845              
- Partials      833      835       +2     
Impacted Files Coverage Δ
pkg/skaffold/cluster/minikube.go 77.77% <82.75%> (+9.15%) ⬆️
pkg/skaffold/util/port.go 89.28% <0.00%> (-2.88%) ⬇️
...kubernetes/portforward/port_forward_integration.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e119e27...8434462. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@briandealwis briandealwis changed the title Revert "Revert mk user flag" Add --user flag to all minikube command invocations Apr 27, 2021
@tejal29 tejal29 enabled auto-merge (squash) April 27, 2021 19:56
@tejal29 tejal29 merged commit 91420a2 into master Apr 27, 2021
@tejal29 tejal29 deleted the revert-5682-revert-mk-user-flag branch April 27, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants