Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert mk user flag #5682

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Revert mk user flag #5682

merged 2 commits into from
Apr 15, 2021

Conversation

gsquared94
Copy link
Contributor

Reverts #5649

@gsquared94 gsquared94 requested a review from a team as a code owner April 15, 2021 03:33
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #5682 (6b8566c) into master (6ba9be2) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
- Coverage   70.70%   70.69%   -0.02%     
==========================================
  Files         411      411              
  Lines       15805    15789      -16     
==========================================
- Hits        11175    11162      -13     
+ Misses       3809     3807       -2     
+ Partials      821      820       -1
Impacted Files Coverage Δ
pkg/skaffold/cluster/minikube.go 68.62% <57.14%> (-3.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba9be2...6b8566c. Read the comment docs.

@gsquared94 gsquared94 merged commit f247da4 into GoogleContainerTools:master Apr 15, 2021
@tejal29 tejal29 mentioned this pull request Apr 20, 2021
Closed
tejal29 added a commit that referenced this pull request Apr 27, 2021
@tejal29
Revert "Revert mk user flag (#5682)"
0a56172 
This reverts commit f247da4.
@tejal29 tejal29 mentioned this pull request Apr 27, 2021
Merged
tejal29 added a commit that referenced this pull request Apr 27, 2021
@tejal29
Add --user flag to all minikube command invocations (#5732)
91420a2 
* Revert "Revert mk user flag (#5682)"

This reverts commit f247da4.

* add more tests and use the right command

* fmt code

* gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsquared94 @briandealwis