-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed metrics credentials and upload metrics if they are present #5157
Conversation
1dbb410
to
3c868c9
Compare
6e72827
to
6cf2c24
Compare
Codecov Report
@@ Coverage Diff @@
## master #5157 +/- ##
==========================================
- Coverage 72.35% 71.85% -0.50%
==========================================
Files 382 384 +2
Lines 13589 13729 +140
==========================================
+ Hits 9832 9865 +33
- Misses 3038 3138 +100
- Partials 719 726 +7
Continue to review full report at Codecov.
|
6cf2c24
to
0f21437
Compare
Took a first pass look at this and it seems good, I think I'd like another pair of eyes on this tho as there's a lot here. I'll take a second pass to make sure I'm not missing anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have one super tiny nit but from what I can gather from the otel docs this seems good
0f21437
to
061bbd4
Compare
061bbd4
to
fb3c3ba
Compare
Description
generate-statik.sh
to look for a secret directory and create a statik package for it.General Flow is:
Follow-up Work