Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold schema get and skaffold credits don't work when secret credentials exist #5253

Closed
IsaacPD opened this issue Jan 20, 2021 · 1 comment · Fixed by #5250
Closed

skaffold schema get and skaffold credits don't work when secret credentials exist #5253

IsaacPD opened this issue Jan 20, 2021 · 1 comment · Fixed by #5250
Labels
kind/bug Something isn't working

Comments

@IsaacPD
Copy link
Contributor

IsaacPD commented Jan 20, 2021

skaffold credits and skaffold schema get fail and don't work as intended when a metrics credential secret is provided during the make process. Basically a repeat of #3428

Expected behavior

skaffold schema get skaffold/v1 prints the schema for skaffold/v1

Actual behavior

skaffold schema get skaffold/v1 prints

schema "skaffold/v1" not found: file does not exist

Information

This should only affect skaffold built after #5157

Steps to reproduce the behavior

  1. export SECRET=~/path/to/some/not-empty/directory
  2. make clean install
  3. Ensure generating statik for secret shows during make
  4. skaffold schema get skaffold/v1
@IsaacPD IsaacPD added the kind/bug Something isn't working label Jan 20, 2021
@IsaacPD IsaacPD changed the title skaffold schema get and skaffold credits don't work when secret cedentials exist skaffold schema get and skaffold credits don't work when secret credentials exist Jan 20, 2021
@IsaacPD
Copy link
Contributor Author

IsaacPD commented Jan 20, 2021

Strangely skaffold credits -d dir when working also doesn't write directly to dir but instead to dir/.. as can be seen here

newPath := path.Join(Path, "..", filePath)

So when running skaffold credits -d ~/credits the output is no different than if running cd ~ && skaffold credits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant