Force correct font to make magnifying glass appear #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacPD
added
the
docs-modifications
IsaacPD
requested review from
a team and
tstromberg
and removed request for
a team
IsaacPD
requested review from
nkubala,
tejal29 and
a team
and removed request for
tstromberg
|
Please visit http://35.236.77.39:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
|
Error creating deployment, please see controller logs for details. |
1 similar comment
|
Error creating deployment, please see controller logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #5017 +/- ##
==========================================
+ Coverage 72.11% 72.15% +0.04%
==========================================
Files 365 365
Lines 12773 12807 +34
==========================================
+ Hits 9211 9241 +30
- Misses 2877 2879 +2
- Partials 685 687 +2
Continue to review full report at Codecov.
|
IsaacPD
added
the
docs-modifications
|
Please visit http://35.236.77.39:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
|
great! its fixed on linux! |
tejal29
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4903
Description
Force use of FontAwesome with '!important' tag. Effectively this changes the font from "Font Awesome 5 Free" to "FontAwesome" which for some unknown reasons fixes the issue above.
User facing changes
The magnifying glass now appears in the search bars across the skaffold site