Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Font Awesome search icon placeholder broken #4903

Closed
thomas-riccardi opened this issue Oct 13, 2020 · 2 comments · Fixed by #5017
Closed

Documentation: Font Awesome search icon placeholder broken #4903

thomas-riccardi opened this issue Oct 13, 2020 · 2 comments · Fixed by #5017
Assignees
Labels
kind/bug Something isn't working meta/docs-preview priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@thomas-riccardi
Copy link

image

The font awesome 5 free web font is somehow not used in the search dom element, so the placeholder isn't substituted.

(changing the font-weight to 900 does make it work, but it's not necessary on upstream docsy demo site https://example.docsy.dev/ ; I stopped the investigation there).

@gsquared94 gsquared94 added meta/docs-preview priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Oct 15, 2020
@gsquared94
Copy link
Contributor

gsquared94 commented Oct 15, 2020

I couldn't figure much out other than if you delete this line:

<script src="https://kit.fontawesome.com/077204b73e.js" crossorigin="anonymous"></script>

then it shows up correctly:
image
but far fa-gem goes missing:
image

Maybe we should explicitly add the font-awesome js and css files instead of using a kit? (Not a frontend dev 😅)

@gsquared94 gsquared94 added the kind/bug Something isn't working label Oct 15, 2020
@IsaacPD
Copy link
Contributor

IsaacPD commented Nov 10, 2020

I managed to make the magnifying glass appear within my browser by changing the font used for that element from "font awesome 5 free" to "FontAwesome"

<div class="skaffold-navbar navbar-nav d-none d-lg-block">{{ partial "search-input.html" . }}</div>

The search-input.html partial is part of docsy so it must be due to one of the style sheets I guess.

Screen Shot 2020-11-10 at 6 31 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working meta/docs-preview priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants