-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating EnvTemplate's use of {{.IMAGE_NAME}} #4533
Deprecating EnvTemplate's use of {{.IMAGE_NAME}} #4533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
==========================================
+ Coverage 72.40% 72.72% +0.32%
==========================================
Files 334 334
Lines 12965 13006 +41
==========================================
+ Hits 9387 9459 +72
+ Misses 2982 2950 -32
- Partials 596 597 +1
Continue to review full report at Codecov.
|
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
Description
This is the coding logic and additional test cases for deprecating envTemplate's use of {{.IMAGE_NAME}} in its template. Users should be using envTemplate to indicate solely the tag value for their images.
User facing changes)
Users will now see a warning that {{.IMAGE_NAME}} is deprecated when using {{.IMAGE_NAME}} in their envTemplate tagger.
The warning will look like
{{.IMAGE_NAME}} is deprecated, envTemplate's template should only specify the tag value. See https://skaffold.dev/docs/pipeline-stages/taggers/
Follow-up Work
Changes to docs to accompany this deprecation: #4532