Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}} #4532

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}} #4532

merged 4 commits into from
Jul 29, 2020

Conversation

felixtran39
Copy link
Contributor

@felixtran39 felixtran39 commented Jul 22, 2020

Description
Changing the docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}}. The link to that PR is: #4533

Depends on PR #4533

@felixtran39 felixtran39 requested a review from a team as a code owner July 22, 2020 23:00
@felixtran39 felixtran39 requested a review from briandealwis July 22, 2020 23:00
@felixtran39 felixtran39 changed the title docs for deprecating env Docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}} Jul 22, 2020
@felixtran39 felixtran39 reopened this Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4532 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4532      +/-   ##
==========================================
+ Coverage   72.39%   72.69%   +0.29%     
==========================================
  Files         334      335       +1     
  Lines       12992    12971      -21     
==========================================
+ Hits         9406     9429      +23     
+ Misses       2987     2949      -38     
+ Partials      599      593       -6     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/kubernetes/client.go 0.00% <0.00%> (-40.00%) ⬇️
pkg/skaffold/kubernetes/context/context.go 85.36% <0.00%> (-12.20%) ⬇️
pkg/skaffold/deploy/labels.go 49.36% <0.00%> (-6.59%) ⬇️
pkg/skaffold/deploy/kubectl/labels.go 87.09% <0.00%> (-6.01%) ⬇️
cmd/skaffold/app/cmd/cmd.go 64.96% <0.00%> (-1.46%) ⬇️
pkg/skaffold/deploy/deploy_mux.go 87.80% <0.00%> (-1.33%) ⬇️
pkg/skaffold/runner/new.go 63.93% <0.00%> (-0.59%) ⬇️
pkg/skaffold/build/build.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 86.36% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1110eb1...44ccfa2. Read the comment docs.

@yuwenma
Copy link
Contributor

yuwenma commented Jul 23, 2020

LGTM!

briandealwis
briandealwis previously approved these changes Jul 25, 2020
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great once #4533 is in.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you'll need to make generate-schemas and add those changes in too.

@briandealwis briandealwis dismissed their stale review July 25, 2020 02:37

Schema needs to be regenerated.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like TestBuild/envTemplate_tagger need to be fixed up?

@felixtran39 felixtran39 requested a review from briandealwis July 28, 2020 18:33
@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label Jul 28, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 28, 2020
@briandealwis briandealwis merged commit f8efbee into GoogleContainerTools:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants