-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}} #4532
Docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}} #4532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4532 +/- ##
==========================================
+ Coverage 72.39% 72.69% +0.29%
==========================================
Files 334 335 +1
Lines 12992 12971 -21
==========================================
+ Hits 9406 9429 +23
+ Misses 2987 2949 -38
+ Partials 599 593 -6
Continue to review full report at Codecov.
|
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great once #4533 is in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you'll need to make generate-schemas
and add those changes in too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like TestBuild/envTemplate_tagger need to be fixed up?
Description
Changing the docs to accommodate the deprecation of envTemplate's use of {{.IMAGE_NAME}}. The link to that PR is: #4533
Depends on PR #4533